linux-kernel - Re: [PATCH 2/2] PCI: tegra: Allow building as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CALHNRZ9M3LYJ1Wi44ZArTt4FQCMwY-VmE8+=qJKbqMezmNGPfw@mail.gmail.com>
Date: Mon, 21 Apr 2025 11:38:06 -0500
From: Aaron Kling <webgeek1234@...il.com>
To: Nicolas Chauvet <kwizart@...il.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Lorenzo Pieralisi <lpieralisi@...nel.org>, 
	Krzysztof Wilczyński <kw@...ux.com>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Rob Herring <robh@...nel.org>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, Thierry Reding <thierry.reding@...il.com>, 
	Jonathan Hunter <jonathanh@...dia.com>, linux-kernel@...r.kernel.org, 
	linux-pci@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH 2/2] PCI: tegra: Allow building as a module

On Mon, Apr 21, 2025 at 9:20 AM Nicolas Chauvet <kwizart@...il.com> wrote:
>
> Le lun. 21 avr. 2025 à 04:59, Aaron Kling via B4 Relay <devnull+webgeek1234.gmail.com@...nel.org> a écrit :
> >
> > From: Aaron Kling <webgeek1234@...il.com>
> >
> > The driver works fine as a module, so allow building as such.
> >
> > Signed-off-by: Aaron Kling <webgeek1234@...il.com>
> > ---
> >  drivers/pci/controller/Kconfig     | 2 +-
> >  drivers/pci/controller/pci-tegra.c | 3 +++
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> > index 9800b768105402d6dd1ba4b134c2ec23da6e4201..a9164dd2eccaead5ae9348c24a5ad75fcb40f507 100644
> > --- a/drivers/pci/controller/Kconfig
> > +++ b/drivers/pci/controller/Kconfig
> > @@ -224,7 +224,7 @@ config PCI_HYPERV_INTERFACE
> >           driver.
> >
> >  config PCI_TEGRA
> > -       bool "NVIDIA Tegra PCIe controller"
> > +       tristate "NVIDIA Tegra PCIe controller"
> >         depends on ARCH_TEGRA || COMPILE_TEST
> >         depends on PCI_MSI
> >         help
> > diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> > index b3cdbc5927de3742161310610dc5dcb836f5dd69..c260842695f2e983ae48fd52b43f62dbb9fb5dd3 100644
> > --- a/drivers/pci/controller/pci-tegra.c
> > +++ b/drivers/pci/controller/pci-tegra.c
> > @@ -2803,3 +2803,6 @@ static struct platform_driver tegra_pcie_driver = {
> >         .remove = tegra_pcie_remove,
> >  };
> >  module_platform_driver(tegra_pcie_driver);
> > +MODULE_AUTHOR("Thierry Reding <treding@...dia.com>");
> > +MODULE_DESCRIPTION("NVIDIA PCI host controller driver");
> > +MODULE_LICENSE("GPL");
>
> Thanks for looking into this.
>
> Last time I checked, building PCI as a module didn't work on Trimslice (Tegra20) at runtime. PCI ethernet failed to bring-up.
> It might be because of the tegra_cpuidle_pcie_irqs_in_use in drivers/cpuidle/cpuidle-tegra.c, see the comments...
> At least this function would need EXPORT_SYMBOL_GPL IIRC.

Ah, I've only been building and testing on arm64, tegra210 and
tegra186. So I missed the arm issues. Not sure I can easily get my
tegra114 or tegra124 setups booting again right now either. Don't have
anything older. But I can at least make sure it builds. Will fix for
v2.

Sincerely,
Aaron