linux-kernel - Re: [PATCH 2/2] iio: dac: ad7293: add adc reference configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d7e6660e0263f167e881bcb32d8d241450a21a66.camel@gmail.com>
Date: Tue, 22 Apr 2025 12:41:44 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>, jic23@...nel.org, 
	robh@...nel.org, conor+dt@...nel.org, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] iio: dac: ad7293: add adc reference configuration

On Tue, 2025-04-22 at 11:55 +0300, Antoniu Miclaus wrote:
> Add support for configurating the ADC reference (internal/external).
> 
> According to the datasheet, the external reference is enabled by
> default.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> ---

LGTM:

Reviewed-by: Nuno Sá <nuno.sa@...log.com>

>  drivers/iio/dac/ad7293.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/drivers/iio/dac/ad7293.c b/drivers/iio/dac/ad7293.c
> index 99fa2d1f8299..c3797e40cdd9 100644
> --- a/drivers/iio/dac/ad7293.c
> +++ b/drivers/iio/dac/ad7293.c
> @@ -114,6 +114,7 @@
>  #define AD7293_REG_DATA_RAW_MSK			GENMASK(15, 4)
>  #define AD7293_REG_VINX_RANGE_GET_CH_MSK(x, ch)	(((x) >> (ch)) & 0x1)
>  #define AD7293_REG_VINX_RANGE_SET_CH_MSK(x, ch)	(((x) & 0x1) << (ch))
> +#define AD7293_GENERAL_ADC_REF_MSK			BIT(7)
>  #define AD7293_CHIP_ID				0x18
>  
>  enum ad7293_ch_type {
> @@ -141,6 +142,7 @@ struct ad7293_state {
>  	/* Protect against concurrent accesses to the device, page selection
> and data content */
>  	struct mutex lock;
>  	struct gpio_desc *gpio_reset;
> +	bool vrefin_en;
>  	u8 page_select;
>  	u8 data[3] __aligned(IIO_DMA_MINALIGN);
>  };
> @@ -785,6 +787,12 @@ static int ad7293_properties_parse(struct ad7293_state
> *st)
>  	if (ret)
>  		return dev_err_probe(&spi->dev, ret, "failed to enable
> VDRIVE\n");
>  
> +	ret = devm_regulator_get_enable_optional(&spi->dev, "vrefin");
> +	if (ret < 0 && ret != -ENODEV)
> +		return dev_err_probe(&spi->dev, ret, "failed to enable
> VREFIN\n");
> +
> +	st->vrefin_en = ret != -ENODEV;
> +
>  	st->gpio_reset = devm_gpiod_get_optional(&st->spi->dev, "reset",
>  						 GPIOD_OUT_HIGH);
>  	if (IS_ERR(st->gpio_reset))
> @@ -818,6 +826,11 @@ static int ad7293_init(struct ad7293_state *st)
>  		return -EINVAL;
>  	}
>  
> +	if (!st->vrefin_en)
> +		return __ad7293_spi_update_bits(st, AD7293_REG_GENERAL,
> +						AD7293_GENERAL_ADC_REF_MSK,
> +						AD7293_GENERAL_ADC_REF_MSK);
> +
>  	return 0;
>  }
>