linux-kernel - Re: [PATCH 2/4] firmware: arm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAeJB4QGjdVPJIoa@hovoldconsulting.com>
Date: Tue, 22 Apr 2025 14:18:15 +0200
From: Johan Hovold <johan@...nel.org>
To: Cristian Marussi <cristian.marussi@....com>
Cc: Sudeep Holla <sudeep.holla@....com>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, arm-scmi@...r.kernel.org,
	james.quinlan@...adcom.com, f.fainelli@...il.com,
	vincent.guittot@...aro.org, peng.fan@....nxp.com,
	michal.simek@....com, quic_sibis@...cinc.com,
	dan.carpenter@...aro.org, maz@...nel.org
Subject: Re: [PATCH 2/4] firmware: arm_scmi: Add Quirks framework

On Tue, Apr 22, 2025 at 12:33:40PM +0100, Cristian Marussi wrote:
> On Tue, Apr 22, 2025 at 12:41:47PM +0200, Johan Hovold wrote:
> > On Thu, Apr 17, 2025 at 03:41:56PM +0100, Sudeep Holla wrote:
> > > On Thu, Apr 17, 2025 at 12:10:25PM +0100, Cristian Marussi wrote:
> > > > On Thu, Apr 17, 2025 at 10:44:24AM +0200, Johan Hovold wrote:

> > > > > of_machine_is_compatible() can be used to match on any compatible
> > > > > string, but not sure if that fits with your current implementation.
> > > 
> > > I was thinking about the same when I looked at the code. Using it is
> > > more elegant IMO.
> > 
> > It would be more flexible, even if you never intend to accept any quirks
> > that matches for an entire SoC.
> 
> I already have a V2 under test that will define a quirk using a
> __VA_ARGS__ so that you can specify a variable number of compats to
> match against the platform running using of_machine_compatible_match()

Sounds good.

> > My understanding is that the version has been bumped now albeit for
> > other reasons than fixing this particular bug. And since enabling FC for
> > these messages should be safe we will probably be able to match on
> > vendor/impl_version here.
> 
> So what is your latest Firmware version read ? no more 0x20000
> 
> [    0.116746] arm-scmi arm-scmi.0.auto: SCMI Protocol ?? 'Qualcom:' Firmware version ???????

It's still 0x20000 for this platform AFAIU, and that probably won't
change even if the fix for this particular bug makes it into the
firmware for the commercial devices.

Johan