linux-kernel - Re: [PATCH] ALSA: pcm: Make snd_pcm_lib_malloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87msc8s64o.wl-tiwai@suse.de>
Date: Tue, 22 Apr 2025 15:00:39 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Chen-Yu Tsai <wenst@...omium.org>
Cc: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: pcm: Make snd_pcm_lib_malloc_pages() debug message say "allocate"

On Mon, 21 Apr 2025 10:52:42 +0200,
Chen-Yu Tsai wrote:
> 
> snd_pcm_lib_malloc_pages() is commonly used for allocating buffers during
> the hw_params callback, whereas preallocating buffers goes through
> preallocate_pcm_pages().
> 
> Having the same terminology in the failure debug messages in both
> misleads developers.
> 
> Change the debug message in snd_pcm_lib_malloc_pages() to use the
> term "allocate" to match its intended use.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@...omium.org>
> ---
> I found this small discrepancy in the ALSA PCM memory management debug
> messages that made it a bit confusing for me to trace code.

Thanks, applied now to for-next branch.


Takashi