linux-kernel - Re: [PATCH] nvmem: zynqmp_nvmem: unbreak driver after cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025042243-gladiator-sizable-a69e@gregkh>
Date: Tue, 22 Apr 2025 15:16:52 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Peter Korsgaard <peter@...sgaard.com>
Cc: Praveen Teja Kundanala <praveen.teja.kundanala@....com>,
	Kalyani Akula <kalyani.akula@....com>,
	Michal Simek <michal.simek@....com>,
	Srinivas Kandagatla <srini@...nel.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmem: zynqmp_nvmem: unbreak driver after cleanup

On Tue, Apr 22, 2025 at 03:08:31PM +0200, Peter Korsgaard wrote:
> Commit 29be47fcd6a0 ("nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup")
> changed the driver to expect the device pointer to be passed as the
> "context", but in nvmem the context parameter comes from nvmem_config.priv
> which is never set - Leading to null pointer exceptions when the device is
> accessed.
> 
> Fixes: 29be47fcd6a0 ("nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup")
> Signed-off-by: Peter Korsgaard <peter@...sgaard.com>
> ---
>  drivers/nvmem/zynqmp_nvmem.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvmem/zynqmp_nvmem.c b/drivers/nvmem/zynqmp_nvmem.c
> index 8682adaacd692..7da717d6c7faf 100644
> --- a/drivers/nvmem/zynqmp_nvmem.c
> +++ b/drivers/nvmem/zynqmp_nvmem.c
> @@ -213,6 +213,7 @@ static int zynqmp_nvmem_probe(struct platform_device *pdev)
>  	econfig.word_size = 1;
>  	econfig.size = ZYNQMP_NVMEM_SIZE;
>  	econfig.dev = dev;
> +	econfig.priv = dev;
>  	econfig.add_legacy_fixed_of_cells = true;
>  	econfig.reg_read = zynqmp_nvmem_read;
>  	econfig.reg_write = zynqmp_nvmem_write;
> -- 
> 2.39.5
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot