linux-kernel - Re: [PATCH] dt-bindings: clock: socfpga: convert to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250422132356.GA1020502-robh@kernel.org>
Date: Tue, 22 Apr 2025 08:23:56 -0500
From: Rob Herring <robh@...nel.org>
To: Matthew Gerlach <matthew.gerlach@...era.com>
Cc: krzk+dt@...nel.org, conor+dt@...nel.org, mturquette@...libre.com,
	dinguyen@...nel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: socfpga: convert to yaml

On Thu, Apr 17, 2025 at 09:06:16AM -0700, Matthew Gerlach wrote:
> Convert the clock device tree bindings to yaml for the Altera SoCFPGA
> Cyclone5, Arria5, and Arria10 chip families. Since the clock nodes are
> subnodes to Altera SOCFPGA Clock Manager, the yaml was added to
> socfpga-clk-manager.yaml.
> 
> Signed-off-by: Matthew Gerlach <matthew.gerlach@...era.com>
> ---
>  .../arm/altera/socfpga-clk-manager.yaml       | 118 +++++++++++++++++-
>  .../bindings/clock/altr_socfpga.txt           |  30 -----
>  2 files changed, 117 insertions(+), 31 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/clock/altr_socfpga.txt
> 
> diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-clk-manager.yaml b/Documentation/devicetree/bindings/arm/altera/socfpga-clk-manager.yaml
> index 572381306681..4cda13259530 100644
> --- a/Documentation/devicetree/bindings/arm/altera/socfpga-clk-manager.yaml
> +++ b/Documentation/devicetree/bindings/arm/altera/socfpga-clk-manager.yaml
> @@ -9,17 +9,133 @@ title: Altera SOCFPGA Clock Manager
>  maintainers:
>    - Dinh Nguyen <dinguyen@...nel.org>
>  
> -description: test
> +description:
> +  This binding describes the Altera SOCFGPA Clock Manager and its associated
> +  tree of clocks, pll's, and clock gates for the Cyclone5, Arria5 and Arria10
> +  chip families.
>  
>  properties:
>    compatible:
>      items:
>        - const: altr,clk-mgr
> +
>    reg:
>      maxItems: 1
>  
> +  clocks:
> +    type: object
> +    additionalProperties: false
> +
> +    properties:
> +      "#address-cells":
> +        const: 1
> +
> +      "#size-cells":
> +        const: 0
> +
> +    patternProperties:
> +      "^osc[0-9]$":
> +        type: object
> +
> +      "^[a-z0-9,_]+[clk,pll,clk_gate,clk_divided](@[a-f0-9]+)?$":

This regex doesn't do what you think it does. You want:

"^[a-z0-9,_]+(clk|pll|clk_gate|clk_divided)(@[a-f0-9]+)?$"

However, I don't see clk_gate or clk_divided used anywhere, so I would 
simplify to:

"(clk|pll)(@[a-f0-9]+)?$"


> +        type: object
> +        additionalProperties: false
> +
> +        properties:
> +
> +          compatible:
> +            enum:
> +              - altr,socfpga-pll-clock
> +              - altr,socfpga-perip-clk
> +              - altr,socfpga-gate-clk
> +              - altr,socfpga-a10-pll-clock
> +              - altr,socfpga-a10-perip-clk
> +              - altr,socfpga-a10-gate-clk
> +              - fixed-clock
> +
> +          clocks:
> +            $ref: /schemas/types.yaml#/definitions/phandle-array

clocks already has a type.

> +            description: one or more phandles to input clock

I assume there is some max, so make this constraints:

minItems: 1
maxItems: ?

> +
> +          "#address-cells":
> +            const: 1
> +
> +          "#clock-cells":
> +            const: 0
> +
> +          "#size-cells":
> +            const: 0
> +
> +          clk-gate:
> +            $ref: /schemas/types.yaml#/definitions/uint32-array
> +            items:
> +              - description: gating register offset
> +              - description: bit index
> +
> +          div-reg:
> +            $ref: /schemas/types.yaml#/definitions/uint32-array
> +            items:
> +              - description: divider register offset
> +              - description: bit shift
> +              - description: bit width
> +
> +          fixed-divider:
> +            $ref: /schemas/types.yaml#/definitions/uint32
> +
> +          reg:
> +            maxItems: 1
> +
> +        patternProperties:
> +          "^[a-z0-9,_]+[clk,pll](@[a-f0-9]+)?$":

Similar issues here.

> +            type: object
> +            additionalProperties: false
> +
> +            properties:
> +              compatible:
> +                enum:
> +                  - altr,socfpga-perip-clk
> +                  - altr,socfpga-gate-clk
> +                  - altr,socfpga-a10-perip-clk
> +                  - altr,socfpga-a10-gate-clk
> +
> +              "#clock-cells":
> +                const: 0
> +
> +              clocks:
> +                $ref: /schemas/types.yaml#/definitions/phandle-array
> +                description: one or more phandles to input clock
> +
> +              clk-gate:
> +                $ref: /schemas/types.yaml#/definitions/uint32-array
> +                items:
> +                  - description: gating register offset
> +                  - description: bit index
> +
> +              div-reg:
> +                $ref: /schemas/types.yaml#/definitions/uint32-array
> +                items:
> +                  - description: divider register offset
> +                  - description: bit shift
> +                  - description: bit width
> +
> +              fixed-divider:
> +                $ref: /schemas/types.yaml#/definitions/uint32

As these properties are all just repeated, put them all under '$defs' 
and reference that in both places.

> +
> +              reg:
> +                maxItems: 1

'reg' goes after compatible.

> +
> +            required:
> +              - compatible
> +              - clocks
> +              - "#clock-cells"
> +
> +        required:
> +          - compatible
> +          - "#clock-cells"
> +
>  required:
>    - compatible
> +  - reg
>  
>  additionalProperties: false
>