linux-kernel - Re: [PATCH V2] XFS: fix zoned gc threshold math for 32-bit arches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb2ddf20-d978-4aab-bbb4-0a3e86fb28df@roeck-us.net>
Date: Tue, 22 Apr 2025 06:56:18 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: cem@...nel.org, linux-xfs@...r.kernel.org
Cc: hch@....de, Hans.Holmberg@....com, linux-kernel@...r.kernel.org,
 oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH V2] XFS: fix zoned gc threshold math for 32-bit arches

On 4/22/25 05:54, cem@...nel.org wrote:
> From: Carlos Maiolino <cem@...nel.org>
> 
> xfs_zoned_need_gc makes use of mult_frac() to calculate the threshold
> for triggering the zoned garbage collector, but, turns out mult_frac()
> doesn't properly work with 64-bit data types and this caused build
> failures on some 32-bit architectures.
> 
> Fix this by essentially open coding mult_frac() in a 64-bit friendly
> way.
> 
> Notice we don't need to bother with counters underflow here because
> xfs_estimate_freecounter() will always return a positive value, as it
> leverages percpu_counter_read_positive to read such counters.
> 
> Fixes: 845abeb1f06a ("xfs: add tunable threshold parameter for triggering zone GC")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202504181233.F7D9Atra-lkp@intel.com/
> Signed-off-by: Carlos Maiolino <cmaiolino@...hat.com>

Succesfully built openrisc:allmodconfig and parisc:allmodconfig with gcc 13.3.

Tested-by: Guenter Roeck <linux@...ck-us.net>

Guenter