linux-kernel - Re: [PATCH v14 1/6] rust: hrtimer: Add Ktime temporarily

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAelbeiWVZgL-kMh@Mac.home>
Date: Tue, 22 Apr 2025 07:19:25 -0700
From: Boqun Feng <boqun.feng@...il.com>
To: FUJITA Tomonori <fujita.tomonori@...il.com>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, andrew@...n.ch, hkallweit1@...il.com,
	tmgross@...ch.edu, ojeda@...nel.org, alex.gaynor@...il.com,
	gary@...yguo.net, bjorn3_gh@...tonmail.com, benno.lossin@...ton.me,
	a.hindborg@...sung.com, aliceryhl@...gle.com,
	anna-maria@...utronix.de, frederic@...nel.org, tglx@...utronix.de,
	arnd@...db.de, jstultz@...gle.com, sboyd@...nel.org,
	mingo@...hat.com, peterz@...radead.org, juri.lelli@...hat.com,
	vincent.guittot@...aro.org, dietmar.eggemann@....com,
	rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
	vschneid@...hat.com, tgunders@...hat.com, me@...enk.dev,
	david.laight.linux@...il.com
Subject: Re: [PATCH v14 1/6] rust: hrtimer: Add Ktime temporarily

On Tue, Apr 22, 2025 at 10:53:30PM +0900, FUJITA Tomonori wrote:
> Add Ktime temporarily until hrtimer is refactored to use Instant and
> Duration types.
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@...il.com>

(Tomo: seems you didn't add me Cced in a few patches, could you add me
Cced for all the patches in the future, thanks!)

Reviewed-by: Boqun Feng <boqun.feng@...il.com>

Regards,
Boqun

> ---
>  rust/kernel/time/hrtimer.rs         | 18 +++++++++++++++++-
>  rust/kernel/time/hrtimer/arc.rs     |  2 +-
>  rust/kernel/time/hrtimer/pin.rs     |  2 +-
>  rust/kernel/time/hrtimer/pin_mut.rs |  4 ++--
>  rust/kernel/time/hrtimer/tbox.rs    |  2 +-
>  5 files changed, 22 insertions(+), 6 deletions(-)
> 
> diff --git a/rust/kernel/time/hrtimer.rs b/rust/kernel/time/hrtimer.rs
> index ce53f8579d18..9fd95f13e53b 100644
> --- a/rust/kernel/time/hrtimer.rs
> +++ b/rust/kernel/time/hrtimer.rs
> @@ -68,10 +68,26 @@
>  //! `start` operation.
>  
>  use super::ClockId;
> -use crate::{prelude::*, time::Ktime, types::Opaque};
> +use crate::{prelude::*, types::Opaque};
>  use core::marker::PhantomData;
>  use pin_init::PinInit;
>  
> +/// A Rust wrapper around a `ktime_t`.
> +// NOTE: Ktime is going to be removed when hrtimer is converted to Instant/Duration.
> +#[repr(transparent)]
> +#[derive(Copy, Clone, PartialEq, PartialOrd, Eq, Ord)]
> +pub struct Ktime {
> +    inner: bindings::ktime_t,
> +}
> +
> +impl Ktime {
> +    /// Returns the number of nanoseconds.
> +    #[inline]
> +    pub fn to_ns(self) -> i64 {
> +        self.inner
> +    }
> +}
> +
>  /// A timer backed by a C `struct hrtimer`.
>  ///
>  /// # Invariants
> diff --git a/rust/kernel/time/hrtimer/arc.rs b/rust/kernel/time/hrtimer/arc.rs
> index 4a984d85b4a1..ccf1e66e5b2d 100644
> --- a/rust/kernel/time/hrtimer/arc.rs
> +++ b/rust/kernel/time/hrtimer/arc.rs
> @@ -5,10 +5,10 @@
>  use super::HrTimerCallback;
>  use super::HrTimerHandle;
>  use super::HrTimerPointer;
> +use super::Ktime;
>  use super::RawHrTimerCallback;
>  use crate::sync::Arc;
>  use crate::sync::ArcBorrow;
> -use crate::time::Ktime;
>  
>  /// A handle for an `Arc<HasHrTimer<T>>` returned by a call to
>  /// [`HrTimerPointer::start`].
> diff --git a/rust/kernel/time/hrtimer/pin.rs b/rust/kernel/time/hrtimer/pin.rs
> index f760db265c7b..293ca9cf058c 100644
> --- a/rust/kernel/time/hrtimer/pin.rs
> +++ b/rust/kernel/time/hrtimer/pin.rs
> @@ -4,9 +4,9 @@
>  use super::HrTimer;
>  use super::HrTimerCallback;
>  use super::HrTimerHandle;
> +use super::Ktime;
>  use super::RawHrTimerCallback;
>  use super::UnsafeHrTimerPointer;
> -use crate::time::Ktime;
>  use core::pin::Pin;
>  
>  /// A handle for a `Pin<&HasHrTimer>`. When the handle exists, the timer might be
> diff --git a/rust/kernel/time/hrtimer/pin_mut.rs b/rust/kernel/time/hrtimer/pin_mut.rs
> index 90c0351d62e4..6033572d35ad 100644
> --- a/rust/kernel/time/hrtimer/pin_mut.rs
> +++ b/rust/kernel/time/hrtimer/pin_mut.rs
> @@ -1,9 +1,9 @@
>  // SPDX-License-Identifier: GPL-2.0
>  
>  use super::{
> -    HasHrTimer, HrTimer, HrTimerCallback, HrTimerHandle, RawHrTimerCallback, UnsafeHrTimerPointer,
> +    HasHrTimer, HrTimer, HrTimerCallback, HrTimerHandle, Ktime, RawHrTimerCallback,
> +    UnsafeHrTimerPointer,
>  };
> -use crate::time::Ktime;
>  use core::{marker::PhantomData, pin::Pin, ptr::NonNull};
>  
>  /// A handle for a `Pin<&mut HasHrTimer>`. When the handle exists, the timer might
> diff --git a/rust/kernel/time/hrtimer/tbox.rs b/rust/kernel/time/hrtimer/tbox.rs
> index 2071cae07234..29526a5da203 100644
> --- a/rust/kernel/time/hrtimer/tbox.rs
> +++ b/rust/kernel/time/hrtimer/tbox.rs
> @@ -5,9 +5,9 @@
>  use super::HrTimerCallback;
>  use super::HrTimerHandle;
>  use super::HrTimerPointer;
> +use super::Ktime;
>  use super::RawHrTimerCallback;
>  use crate::prelude::*;
> -use crate::time::Ktime;
>  use core::ptr::NonNull;
>  
>  /// A handle for a [`Box<HasHrTimer<T>>`] returned by a call to
> -- 
> 2.43.0
> 
>