linux-kernel - Re: [PATCH v2] lib: PRIME_NUMBERS_KUNIT_TEST should not select PRIME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e03d4e6-5ae7-4fb9-b072-051d4e24f413@sirena.org.uk>
Date: Tue, 22 Apr 2025 16:17:28 +0100
From: Mark Brown <broonie@...nel.org>
To: Kees Cook <kees@...nel.org>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>,
	Tamir Duberstein <tamird@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Brendan Higgins <brendan.higgins@...ux.dev>,
	David Gow <davidgow@...gle.com>, Rae Moar <rmoar@...gle.com>,
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] lib: PRIME_NUMBERS_KUNIT_TEST should not select
 PRIME_NUMBERS

On Tue, Apr 22, 2025 at 08:03:09AM -0700, Kees Cook wrote:
> On Tue, Apr 22, 2025 at 01:10:47PM +0100, Mark Brown wrote:

> > This commit, which is now in mainline, causes the prime numbers test to
> > vanish from my CI which is a regression - the selftests config fragment
> > is obviously not picked up by the kunit runner when it builds the
> > kernel.  You should add any KUnit tests to one of the configs in
> > tools/testing/kunit/configs/ - generally all_tests.config.

> Ah! Thanks -- I forgot about these (apparently my memory horizon is at
> most 2 years, considering commit 4d9060981f88 ("kunit: tool: Enable
> CONFIG_FORTIFY_SOURCE under UML").

> Does this look like you're expecting?

Yes, in fact I actually have roughly that patch in my CI already.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)