linux-kernel - Re: [PATCH 01/12] dt-bindings: riscv: Add xsfvqmaccdod and xsfvqmaccqoq ISA extension description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250422-poise-tighten-aed2c0aae830@spud>
Date: Tue, 22 Apr 2025 16:17:54 +0100
From: Conor Dooley <conor@...nel.org>
To: Cyan Yang <cyan.yang@...ive.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	corbet@....net, paul.walmsley@...ive.com, palmer@...belt.com,
	aou@...s.berkeley.edu, alex@...ti.fr, samuel.holland@...ive.com,
	linux-doc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/12] dt-bindings: riscv: Add xsfvqmaccdod and
 xsfvqmaccqoq ISA extension description

On Fri, Apr 18, 2025 at 01:32:28PM +0800, Cyan Yang wrote:
> Add "xsfvqmaccdod" and "xsfvqmaccqoq" ISA extensions which are provided by
> SiFive for int8 matrix multiplication instructions support.
> 
> Signed-off-by: Cyan Yang <cyan.yang@...ive.com>

If these have some dependencies, please look at how other extensions
have made them required. Otherwise all three dt-binding patches look
fine. I'll leave acks on them all, but with the condition that you
should make dependencies required.

Acked-by: Conor Dooley <conor.dooley@...rochip.com>

> ---
>  .../devicetree/bindings/riscv/extensions.yaml       | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml
> index bcab59e0cc2e..d36e7c68d69a 100644
> --- a/Documentation/devicetree/bindings/riscv/extensions.yaml
> +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml
> @@ -662,6 +662,19 @@ properties:
>              Registers in the AX45MP datasheet.
>              https://www.andestech.com/wp-content/uploads/AX45MP-1C-Rev.-5.0.0-Datasheet.pdf
>  
> +        # SiFive
> +        - const: xsfvqmaccdod
> +          description:
> +            SiFive Int8 Matrix Multiplication Extensions Specification.
> +            See more details in
> +            https://www.sifive.com/document-file/sifive-int8-matrix-multiplication-extensions-specification
> +
> +        - const: xsfvqmaccqoq
> +          description:
> +            SiFive Int8 Matrix Multiplication Extensions Specification.
> +            See more details in
> +            https://www.sifive.com/document-file/sifive-int8-matrix-multiplication-extensions-specification
> +
>          # T-HEAD
>          - const: xtheadvector
>            description:
> -- 
> 2.39.5 (Apple Git-154)
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)