linux-kernel - Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAe0O50RmUw3k0o9@smile.fi.intel.com>
Date: Tue, 22 Apr 2025 18:22:35 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Aditya Garg <gargaditya08@...e.com>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>,
	Hector Martin <marcan@...can.st>, alyssa@...enzweig.io,
	Petr Mladek <pmladek@...e.com>, Sven Peter <sven@...npeter.dev>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Aun-Ali Zaidi <admin@...eit.net>,
	Maxime Ripard <mripard@...nel.org>, airlied@...hat.com,
	Simona Vetter <simona@...ll.ch>,
	Steven Rostedt <rostedt@...dmis.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Jonathan Corbet <corbet@....net>,
	Andrew Morton <akpm@...ux-foundation.org>, apw@...onical.com,
	joe@...ches.com, dwaipayanray1@...il.com, lukas.bulwahn@...il.com,
	Kees Cook <kees@...nel.org>, tamird@...il.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	dri-devel@...ts.freedesktop.org, linux-doc@...r.kernel.org,
	Asahi Linux Mailing List <asahi@...ts.linux.dev>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by
 extending %p4cc

On Tue, Apr 22, 2025 at 08:45:31PM +0530, Aditya Garg wrote:
> On 22-04-2025 04:02 pm, Geert Uytterhoeven wrote:
> > On Tue, 22 Apr 2025 at 12:16, Andy Shevchenko
> > <andriy.shevchenko@...ux.intel.com> wrote:

...

> > I am not against h/n in se, but I am against bad/confusing naming.
> > The big question is: should it print
> >   (A) the value in network byte order, or
> >   (B) the reverse of host byte order?
> > 
> > If the answer is (A), I see no real reason to have %p4n, as %p4b prints
> > the exact same thing.  Moreover, it leaves us without a portable
> > way to print values in reverse without the caller doing an explicit
> > __swab32() (which is not compatible with the %p pass-by-pointer
> > calling convention).
> > 
> > If the answer is (B), "%p4n using network byte order" is bad/confusing
> > naming.
> 
> The answer is definitely (B). As far as bad/confusing naming is concerned,
> I'll let vsprintf maintainers decide. As far as usage is concerned, %p4cl
> is used in appletbdrm and %p4ch is used in to be upstreamed soon smc driver
> by Asahi Linux.

Can it use %p4cb? Or in another word,
why does it require "host" representation?

-- 
With Best Regards,
Andy Shevchenko