| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aAe5937NqfE_c34-@smile.fi.intel.com> Date: Tue, 22 Apr 2025 18:47:03 +0300 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: xiaopeitux@...mail.com Cc: john.g.garry@...cle.com, linux-kernel@...r.kernel.org, robh@...nel.org, xiaopei01@...inos.cn, xuwei5@...ilicon.com Subject: Re: [PATCH 1/3 V2] bus: hisi_lpc: remove unused head file in hisi_lpc.c On Tue, Apr 22, 2025 at 07:31:22PM +0800, xiaopeitux@...mail.com wrote: > From: Pei Xiao <xiaopei01@...inos.cn> > > linux/console.h,linux/pci.h,linux/slab.h > are not used, removes it. There are more unused and many are missed. My diff looks like this: diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c index 53dd1573e323..4911afdac316 100644 --- a/drivers/bus/hisi_lpc.c +++ b/drivers/bus/hisi_lpc.c @@ -7,17 +7,22 @@ */ #include <linux/acpi.h> -#include <linux/console.h> +#include <linux/bits.h> #include <linux/delay.h> +#include <linux/err.h> #include <linux/io.h> +#include <linux/ioport.h> #include <linux/logic_pio.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> -#include <linux/of.h> #include <linux/of_platform.h> -#include <linux/pci.h> #include <linux/platform_device.h> +#include <linux/property.h> #include <linux/serial_8250.h> -#include <linux/slab.h> +#include <linux/spinlock.h> +#include <linux/types.h> + +#include <asm/byteorder.h> #define DRV_NAME "hisi-lpc" ... > #include <linux/acpi.h> > -#include <linux/console.h> > #include <linux/delay.h> > #include <linux/io.h> > #include <linux/logic_pio.h> > #include <linux/module.h> > #include <linux/of.h> > #include <linux/of_platform.h> > -#include <linux/pci.h> > #include <linux/platform_device.h> > #include <linux/serial_8250.h> > -#include <linux/slab.h> -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists