linux-kernel - Re: [PATCH v2 0/4] PCI/arm64/ath11k/ath12k: Rename pwrctrl Kconfig symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250422160925.GA331992@bhelgaas>
Date: Tue, 22 Apr 2025 11:09:25 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Johan Hovold <johan+linaro@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>
Cc: Bartosz Golaszewski <brgl@...ev.pl>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Jeff Johnson <jjohnson@...nel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Jonas Gorski <jonas.gorski@...il.com>, linux-pci@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, ath11k@...ts.infradead.org,
	ath12k@...ts.infradead.org, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/4] PCI/arm64/ath11k/ath12k: Rename pwrctrl Kconfig
 symbols

[cc->to Catalin, Will: note the arm64 Kconfig change; my understanding
is that this shouldn't break existing configs]

On Wed, Apr 02, 2025 at 03:26:30PM +0200, Johan Hovold wrote:
> The PCI pwrctrl framework was renamed after being merged, but the
> Kconfig symbols still reflect the old name ("pwrctl" without an "r").
> 
> This leads to people not knowing how to refer to the framework in
> writing, inconsistencies in module naming, etc.
> 
> Let's rename also the Kconfig symbols before this gets any worse.
> 
> The ath11k, ath12k and arm64 changes could go theoretically go through
> the corresponding subsystem trees in turn once they have the new
> symbols, but to avoid tracking dependencies over multiple cycles it is
> much preferred to have all of these go in through the PCI tree.
> 
> The wifi patches have been acked by Jeff and I don't think Will or
> Catalin will mind the single rename in arm64 if they don't see this
> message in time.
> 
> Note that the patches could be squashed into one, but keeping them
> separate highlights the changes done to other subsystems. I also find it
> easier to review the changes this way.
> 
> There are some new pwrctrl drivers and an arm64 defconfig change on the
> lists, but the former should also go in through PCI anyway while we can
> make sure that the defconfig update matches the new slot symbol.
> 
> Note that getting this rename into rc1 would be great as that way it
> would end up in most subsystem trees soon as well.
> 
> Johan
> 
> 
> Changes in v2:
>  - drop deprecated symbol for the new slot driver to avoid having to a
>    add a new user visible symbol (e.g. any early adopters will be asked
>    to enable the renamed option again)
> 
>  - move arm64 patch last two avoid temporarily not having the pwrseq
>    driver selected (Jonas)
> 
> Johan Hovold (4):
>   PCI/pwrctrl: Rename pwrctrl Kconfig symbols and slot module
>   wifi: ath11k: switch to PCI_PWRCTRL_PWRSEQ
>   wifi: ath12k: switch to PCI_PWRCTRL_PWRSEQ
>   arm64: Kconfig: switch to HAVE_PWRCTRL
> 
>  arch/arm64/Kconfig.platforms            |  2 +-
>  drivers/net/wireless/ath/ath11k/Kconfig |  2 +-
>  drivers/net/wireless/ath/ath12k/Kconfig |  2 +-
>  drivers/pci/pwrctrl/Kconfig             | 22 ++++++++++++++++------
>  drivers/pci/pwrctrl/Makefile            |  8 ++++----
>  5 files changed, 23 insertions(+), 13 deletions(-)

Applied to pci/pwrctrl for v6.16, thanks!