linux-kernel - Re: [PATCH v1 8/8] arm64: dts: qcom: qcm6490-idp: Add sound card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc69172d-1e7d-4aff-8c85-baeee587a771@quicinc.com>
Date: Tue, 22 Apr 2025 22:51:29 +0530
From: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>
CC: <cros-qcom-dts-watchers@...omium.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@....qualcomm.com>, Mohammad Rafi Shaik <quic_mohs@...cinc.com>
Subject: Re: [PATCH v1 8/8] arm64: dts: qcom: qcm6490-idp: Add sound card



On 3/27/2025 4:42 AM, Bryan O'Donoghue wrote:
> On 17/03/2025 05:41, Prasad Kumpatla wrote:
>> Add the sound card node with tested playback over WSA8835 speakers,
>> msm mic along with wcd9370 headset playabck and record.
> 
> I think as a reviewer I'd like a better description.
> 
> "msm mic" doesn't mean much - please specify the number of MICs and 
> their type - "four digital mics"
> 
> MSM Mics are not a meaningful description.

ACK,
Will provide proper description in next patchset version.

Thanks,
Prasad>
> ---
> bod