linux-kernel - Re: [PATCH v4 09/39] x86/vdso: Enable sframe generation in VDSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250422134401.55178c36@gandalf.local.home>
Date: Tue, 22 Apr 2025 13:44:01 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: Jens Remus <jremus@...ux.ibm.com>, x86@...nel.org, Peter Zijlstra
 <peterz@...radead.org>, Ingo Molnar <mingo@...nel.org>, Arnaldo Carvalho de
 Melo <acme@...nel.org>, linux-kernel@...r.kernel.org, Indu Bhagat
 <indu.bhagat@...cle.com>, Mark Rutland <mark.rutland@....com>, Alexander
 Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa
 <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>, Ian Rogers
 <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>,
 linux-perf-users@...r.kernel.org, Mark Brown <broonie@...nel.org>,
 linux-toolchains@...r.kernel.org, Jordan Rome <jordalgo@...a.com>, Sam
 James <sam@...too.org>, linux-trace-kernel@...r.kernel.org, Andrii Nakryiko
 <andrii.nakryiko@...il.com>, Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>, Florian Weimer <fweimer@...hat.com>, Andy
 Lutomirski <luto@...nel.org>, Masami Hiramatsu <mhiramat@...nel.org>,
 Weinan Liu <wnliu@...gle.com>, Heiko Carstens <hca@...ux.ibm.com>, Vasily
 Gorbik <gor@...ux.ibm.com>
Subject: Re: [PATCH v4 09/39] x86/vdso: Enable sframe generation in VDSO

On Fri, 24 Jan 2025 08:43:32 -0800
Josh Poimboeuf <jpoimboe@...nel.org> wrote:

> On Fri, Jan 24, 2025 at 05:00:27PM +0100, Jens Remus wrote:
> > On 22.01.2025 03:31, Josh Poimboeuf wrote:  
> > > diff --git a/arch/x86/include/asm/dwarf2.h b/arch/x86/include/asm/dwarf2.h
> > > index b195b3c8677e..1c354f648505 100644
> > > --- a/arch/x86/include/asm/dwarf2.h
> > > +++ b/arch/x86/include/asm/dwarf2.h
> > > @@ -12,8 +12,11 @@
> > >   	 * For the vDSO, emit both runtime unwind information and debug
> > >   	 * symbols for the .dbg file.
> > >   	 */
> > > -  
> > 
> > Nit: Deleted blank line you introduced in "[PATCH v4 05/39] x86/asm:
> > Avoid emitting DWARF CFI for non-VDSO".  
> 
> Indeed.

Note, I'm getting ready to send out an update of Josh's patches.

This particular nit isn't really an issue, as #ifdef's do sometimes replace
blank lines.

Just mentioning this so you don't think I'm ignoring it, when I post patches.

-- Steve