linux-kernel - Re: [PATCH] lib: Ensure prime numbers tests are included in KUnit test runs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWj_bap0Lb3OXuLQBfLwTVVD0_-Jpm-VYf6fbFfK8MOUw@mail.gmail.com>
Date: Tue, 22 Apr 2025 20:18:35 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Mark Brown <broonie@...nel.org>
Cc: Brendan Higgins <brendan.higgins@...ux.dev>, David Gow <davidgow@...gle.com>, 
	Rae Moar <rmoar@...gle.com>, Tamir Duberstein <tamird@...il.com>, Kees Cook <kees@...nel.org>, 
	linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib: Ensure prime numbers tests are included in KUnit
 test runs

Hi Mark,

Thanks for your patch!

On Tue, 22 Apr 2025 at 17:43, Mark Brown <broonie@...nel.org> wrote:
> When the select of PRIME_MUMBERS was removed from it's KUnit test
> Kconfig nothing was added to the KUnit configs, meaning that when run
> via the KUnit runner the tests are neither built nor run.  Add
> PRIME_NUMBERS to all_tests.config so they are enabled when the KUnit
> runner builds the kernel.
>
> Fixes: 3f2925174f8b ("lib/prime_numbers: KUnit test should not select PRIME_NUMBERS")

Sorry, I wasn't aware there was yet another config file that needed
an update...

> Signed-off-by: Mark Brown <broonie@...nel.org>

> --- a/tools/testing/kunit/configs/all_tests.config
> +++ b/tools/testing/kunit/configs/all_tests.config

Given this is the sole file that contains CONFIG_REGMAP_BUILD=y,
it must be the right one ;-)

> @@ -43,6 +43,8 @@ CONFIG_REGMAP_BUILD=y
>
>  CONFIG_AUDIT=y
>
> +CONFIG_PRIME_NUMBERS=y
> +
>  CONFIG_SECURITY=y
>  CONFIG_SECURITY_APPARMOR=y
>  CONFIG_SECURITY_LANDLOCK=y

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds