linux-kernel - Re: [PATCH net-next] rxrpc: Remove deadcode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250422182229.GM2843373@horms.kernel.org>
Date: Tue, 22 Apr 2025 19:22:29 +0100
From: Simon Horman <horms@...nel.org>
To: linux@...blig.org
Cc: dhowells@...hat.com, marc.dionne@...istor.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	corbet@....net, linux-afs@...ts.infradead.org,
	netdev@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] rxrpc: Remove deadcode

On Thu, Apr 17, 2025 at 04:32:32PM +0100, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> Remove three functions that are no longer used.
> 
> rxrpc_get_txbuf() last use was removed by 2020's
> commit 5e6ef4f1017c ("rxrpc: Make the I/O thread take over the call and
> local processor work")
> 
> rxrpc_kernel_get_epoch() last use was removed by 2020's
> commit 44746355ccb1 ("afs: Don't get epoch from a server because it may be
> ambiguous")
> 
> rxrpc_kernel_set_max_life() last use was removed by 2023's
> commit db099c625b13 ("rxrpc: Fix timeout of a call that hasn't yet been
> granted a channel")
> 
> Both of the rxrpc_kernel_* functions were documented.  Remove that
> documentation as well as the code.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Hi David,

This patch doesn't apply to net-next.  Probably because of commit
23738cc80483 ("rxrpc: Pull out certain app callback funcs into an ops
table"). So please rebase and repost.

But other than that, this patch looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>

...

-- 
pw-bot: changes-requested