linux-kernel - Re: [RFC PATCH v2 00/34] MSR refactor with new MSR instructions support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAfzOWnYzcPjZDEI@google.com>
Date: Tue, 22 Apr 2025 12:51:21 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Ingo Molnar <mingo@...nel.org>
Cc: Tony Luck <tony.luck@...el.com>, Xin Li <xin@...or.com>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>, 
	"linux-perf-users@...r.kernel.org" <linux-perf-users@...r.kernel.org>, 
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>, 
	"virtualization@...ts.linux.dev" <virtualization@...ts.linux.dev>, 
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, 
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>, 
	"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>, 
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, 
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>, 
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>, 
	"tglx@...utronix.de" <tglx@...utronix.de>, "mingo@...hat.com" <mingo@...hat.com>, "bp@...en8.de" <bp@...en8.de>, 
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>, "x86@...nel.org" <x86@...nel.org>, 
	"hpa@...or.com" <hpa@...or.com>, "acme@...nel.org" <acme@...nel.org>, "jgross@...e.com" <jgross@...e.com>, 
	"andrew.cooper3@...rix.com" <andrew.cooper3@...rix.com>, "peterz@...radead.org" <peterz@...radead.org>, 
	"namhyung@...nel.org" <namhyung@...nel.org>, "mark.rutland@....com" <mark.rutland@....com>, 
	"alexander.shishkin@...ux.intel.com" <alexander.shishkin@...ux.intel.com>, "jolsa@...nel.org" <jolsa@...nel.org>, 
	"irogers@...gle.com" <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, 
	"kan.liang@...ux.intel.com" <kan.liang@...ux.intel.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>, 
	"ajay.kaher@...adcom.com" <ajay.kaher@...adcom.com>, 
	"bcm-kernel-feedback-list@...adcom.com" <bcm-kernel-feedback-list@...adcom.com>, 
	"pbonzini@...hat.com" <pbonzini@...hat.com>, "vkuznets@...hat.com" <vkuznets@...hat.com>, 
	"luto@...nel.org" <luto@...nel.org>, Boris Ostrovsky <boris.ostrovsky@...cle.com>, 
	"kys@...rosoft.com" <kys@...rosoft.com>, "haiyangz@...rosoft.com" <haiyangz@...rosoft.com>, 
	Dexuan Cui <decui@...rosoft.com>
Subject: Re: [RFC PATCH v2 00/34] MSR refactor with new MSR instructions support

On Tue, Apr 22, 2025, Ingo Molnar wrote:
> 
> * Luck, Tony <tony.luck@...el.com> wrote:
> 
> > > >> base-commit: f30a0c0d2b08b355c01392538de8fc872387cb2b
> > > >
> > > > This commit doesn't exist in Linus' tree or the tip tree, and the series doesn't
> > > > apply cleanly on any of the "obvious" choices.  Reviewing a 34 patches series
> > > > without being able to apply it is a wee bit difficult...
> > > >
> > >
> > > $ git show f30a0c0d2b08b355c01392538de8fc872387cb2b
> > > commit f30a0c0d2b08b355c01392538de8fc872387cb2b
> > > Merge: 49b517e68cf7 e396dd85172c
> > > Author: Ingo Molnar <mingo@...nel.org>
> > > Date:   Tue Apr 22 08:37:32 2025 +0200
> > >
> > >      Merge branch into tip/master: 'x86/sev'
> > >
> > >       # New commits in x86/sev:
> > >          e396dd85172c ("x86/sev: Register tpm-svsm platform device")
> > >          93b7c6b3ce91 ("tpm: Add SNP SVSM vTPM driver")
> > >          b2849b072366 ("svsm: Add header with SVSM_VTPM_CMD helpers")
> > >          770de678bc28 ("x86/sev: Add SVSM vTPM probe/send_command
> > > functions")
> > >
> > >      Signed-off-by: Ingo Molnar <mingo@...nel.org>
> > >
> > >
> > > You probably need to git pull from the tip tree :-)
> > 
> > If possible, you should avoid basing a series on tip/master as it 
> > gets recreated frequently by merging all the topic branches. The SHA1 
> > is here today, gone tomorrow.
> 
> Correct, although for x86 patch submissions via email it's not wrong: 
> what applies today will likely apply tomorrow as well, regardless of 
> the SHA1 change. :-)

Yeah, but as Tony pointed out, when using base commit that may be ephemeral, then
the cover letter needs to call out the tree+branch.  This series applies on the
current tip/master, but there was nothing to clue me into that fact.