linux-kernel - Re: [PATCH] media: amphion: fix potential NULL deref in vpu_core_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b24a722c7d41eeddc02b81226132aa55d7a82bf3.camel@ndufresne.ca>
Date: Tue, 22 Apr 2025 17:16:50 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Markus Elfring <Markus.Elfring@....de>, Chenyuan Yang
 <chenyuan0y@...il.com>, 	linux-media@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Charles Han
 <hanchunchao@...pur.com>,  Hans Verkuil <hverkuil@...all.nl>, Mauro
 Carvalho Chehab <mchehab@...nel.org>, Ming Qian <ming.qian@....com>, 
 Shijie Qin <shijie.qin@....com>, Zhou Peng <eagle.zhou@....com>
Subject: Re: [PATCH] media: amphion: fix potential NULL deref in
 vpu_core_parse_dt()

Hi Markus,

Le samedi 12 avril 2025 à 17:15 +0200, Markus Elfring a écrit :
> > The result of memremap() may be NULL on failure, leading to a null
> > dereference in the subsequent memset(). Add explicit checks after
> > each memremap() call: if the firmware region fails to map, return
> > immediately; if the RPC region fails, unmap the firmware window before
> > returning.
> 
> * Do you propose to complete the error handling?
> 
> * Can any other summary phrase variant become more desirable accordingly?

That could equally be a machine replying. I'm happy to get help with
reviews, but his isn't useful. It simply confuses the least experienced
submitters.

> 
> * Please avoid duplicate source code (also for corresponding exception handling).

This type of comment only make sense inline, there is no true
duplication either.

> 
> 
> See also:
> [PATCH] media: amphion: fix potential NULL deref in vpu_core_parse_dt
> https://lore.kernel.org/all/20250407084829.5755-1-hanchunchao@inspur.com/

I already stated I prefer this version.

Nicolas