linux-kernel - Re: [PATCH] media: imagination: fix a potential memory leak in e5010

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac48df7034ce695363daae2e5d87e00d6d41b038.camel@ndufresne.ca>
Date: Tue, 22 Apr 2025 17:29:42 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Haoxiang Li <haoxiang_li2024@....com>, devarsht@...com,
 mchehab@...nel.org, 	hverkuil@...all.nl, d-huang@...com,
 benjamin.gaignard@...labora.com, 	sebastian.fricke@...labora.com
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH] media: imagination: fix a potential memory leak in
 e5010_probe()

Hi,

Le mercredi 26 février 2025 à 20:49 +0800, Haoxiang Li a écrit :
> Add video_device_release() to release the memory allocated by
> video_device_alloc() if something goes wrong.
> 
> Fixes: a1e294045885 ("media: imagination: Add E5010 JPEG Encoder driver")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@....com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@...labora.com>

> ---
>  drivers/media/platform/imagination/e5010-jpeg-enc.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/imagination/e5010-jpeg-enc.c b/drivers/media/platform/imagination/e5010-jpeg-enc.c
> index c194f830577f..53e501b5ac0a 100644
> --- a/drivers/media/platform/imagination/e5010-jpeg-enc.c
> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c
> @@ -1057,8 +1057,11 @@ static int e5010_probe(struct platform_device *pdev)
>  	e5010->vdev->lock = &e5010->mutex;
>  
>  	ret = v4l2_device_register(dev, &e5010->v4l2_dev);
> -	if (ret)
> -		return dev_err_probe(dev, ret, "failed to register v4l2 device\n");
> +	if (ret) {
> +		dev_err_probe(dev, ret, "failed to register v4l2 device\n");
> +		goto fail_after_video_device_alloc;
> +	}
> +
>  
>  	e5010->m2m_dev = v4l2_m2m_init(&e5010_m2m_ops);
>  	if (IS_ERR(e5010->m2m_dev)) {
> @@ -1118,6 +1121,8 @@ static int e5010_probe(struct platform_device *pdev)
>  	v4l2_m2m_release(e5010->m2m_dev);
>  fail_after_v4l2_register:
>  	v4l2_device_unregister(&e5010->v4l2_dev);
> +fail_after_video_device_alloc:
> +	video_device_release(e5010->vdev);
>  	return ret;
>  }
>