linux-kernel - Re: [PATCH v4 0/2] nvme/pci: PRP list DMA pool partitioning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADUfDZr5nq9fAvxSZJwUmuZKry6pHqLrucLtJLmV8cAvZ6O6eg@mail.gmail.com>
Date: Tue, 22 Apr 2025 15:04:37 -0700
From: Caleb Sander Mateos <csander@...estorage.com>
To: Keith Busch <kbusch@...nel.org>
Cc: Jens Axboe <axboe@...nel.dk>, Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>, 
	Kanchan Joshi <joshi.k@...sung.com>, linux-nvme@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/2] nvme/pci: PRP list DMA pool partitioning

On Tue, Apr 22, 2025 at 10:48 AM Keith Busch <kbusch@...nel.org> wrote:
>
> On Tue, Apr 22, 2025 at 10:19:57AM -0600, Caleb Sander Mateos wrote:
> > This reduces the _raw_spin_lock_irqsave overhead by about half, to
> > 1.2%.
>
> Could you try this atop your series? I hope to see if we can squeeze a
> little more out by keeping the spinlock and list links local to the node
> using them.

That does help save some CPU time in dma_pool_alloc too. It's down
from 0.87% of CPU time to 0.52% while doing 5% more IOPS. I'll include
your patch (with a few tweaks) in a v5 of this series. Hopefully
you're okay if I include your Signed-off-by.

Thanks,
Caleb