linux-kernel - Re: [PATCH v1 2/5] drm/mediatek: mtk_dpi: Add local helpers for bus format parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05abf54038b2fb066c64d0975ca2fe06e8c5be7f.camel@mediatek.com>
Date: Tue, 22 Apr 2025 04:00:14 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>
CC: Lewis Liao (廖柏鈞) <Lewis.Liao@...iatek.com>,
	Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>,
	Ives Chenjh (陳俊弘) <Ives.Chenjh@...iatek.com>,
	"simona@...ll.ch" <simona@...ll.ch>,
	TommyYL Chen (陳彥良) <TommyYL.Chen@...iatek.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"airlied@...il.com" <airlied@...il.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"kernel@...labora.com" <kernel@...labora.com>
Subject: Re: [PATCH v1 2/5] drm/mediatek: mtk_dpi: Add local helpers for bus
 format parameters

On Wed, 2025-04-09 at 15:13 +0200, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> In preparation for adding support for additional color formats,
> add local helpers to map media bus format parameters to this
> driver's bit_num, channel_swap and color_format.
> 
> This commit brings no functional changes.

Reviewed-by: CK Hu <ck.hu@...iatek.com>

> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dpi.c | 46 ++++++++++++++++++++++++++----
>  1 file changed, 40 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index d735398e97f8..5a66dfe3ad40 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -738,6 +738,43 @@ static u32 *mtk_dpi_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge,
>         return input_fmts;
>  }
> 
> +static unsigned int mtk_dpi_bus_fmt_bit_num(unsigned int out_bus_format)
> +{
> +       switch (out_bus_format) {
> +       default:
> +       case MEDIA_BUS_FMT_RGB888_1X24:
> +       case MEDIA_BUS_FMT_RGB888_2X12_LE:
> +       case MEDIA_BUS_FMT_RGB888_2X12_BE:
> +       case MEDIA_BUS_FMT_YUYV8_1X16:
> +               return MTK_DPI_OUT_BIT_NUM_8BITS;
> +       }
> +}
> +
> +static unsigned int mtk_dpi_bus_fmt_channel_swap(unsigned int out_bus_format)
> +{
> +       switch (out_bus_format) {
> +       default:
> +       case MEDIA_BUS_FMT_RGB888_1X24:
> +       case MEDIA_BUS_FMT_RGB888_2X12_LE:
> +       case MEDIA_BUS_FMT_RGB888_2X12_BE:
> +       case MEDIA_BUS_FMT_YUYV8_1X16:
> +               return MTK_DPI_OUT_CHANNEL_SWAP_RGB;
> +       }
> +}
> +
> +static unsigned int mtk_dpi_bus_fmt_color_format(unsigned int out_bus_format)
> +{
> +       switch (out_bus_format) {
> +       default:
> +       case MEDIA_BUS_FMT_RGB888_1X24:
> +       case MEDIA_BUS_FMT_RGB888_2X12_LE:
> +       case MEDIA_BUS_FMT_RGB888_2X12_BE:
> +               return MTK_DPI_COLOR_FORMAT_RGB;
> +       case MEDIA_BUS_FMT_YUYV8_1X16:
> +               return MTK_DPI_COLOR_FORMAT_YCBCR_422;
> +       }
> +}
> +
>  static int mtk_dpi_bridge_atomic_check(struct drm_bridge *bridge,
>                                        struct drm_bridge_state *bridge_state,
>                                        struct drm_crtc_state *crtc_state,
> @@ -757,13 +794,10 @@ static int mtk_dpi_bridge_atomic_check(struct drm_bridge *bridge,
>                 bridge_state->output_bus_cfg.format);
> 
>         dpi->output_fmt = out_bus_format;
> -       dpi->bit_num = MTK_DPI_OUT_BIT_NUM_8BITS;
> -       dpi->channel_swap = MTK_DPI_OUT_CHANNEL_SWAP_RGB;
> +       dpi->bit_num = mtk_dpi_bus_fmt_bit_num(out_bus_format);
> +       dpi->channel_swap = mtk_dpi_bus_fmt_channel_swap(out_bus_format);
>         dpi->yc_map = MTK_DPI_OUT_YC_MAP_RGB;
> -       if (out_bus_format == MEDIA_BUS_FMT_YUYV8_1X16)
> -               dpi->color_format = MTK_DPI_COLOR_FORMAT_YCBCR_422;
> -       else
> -               dpi->color_format = MTK_DPI_COLOR_FORMAT_RGB;
> +       dpi->color_format = mtk_dpi_bus_fmt_color_format(out_bus_format);
> 
>         return 0;
>  }
> --
> 2.49.0
>