lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20250422144321.3879d891@canb.auug.org.au>
Date: Tue, 22 Apr 2025 14:43:21 +1000
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Steffen Klassert <steffen.klassert@...unet.com>, David Miller
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>
Cc: Networking <netdev@...r.kernel.org>, Cosmin Ratiu <cratiu@...dia.com>,
 Jedrzej Jagielski <jedrzej.jagielski@...el.com>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, Linux Next Mailing List
 <linux-next@...r.kernel.org>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>
Subject: linux-next: manual merge of the ipsec-next tree with the net-next
 tree

Hi all,

Today's linux-next merge of the ipsec-next tree got a conflict in:

  drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c

between commit:

  fd5ef5203ce6 ("ixgbe: wrap netdev_priv() usage")

from the net-next tree and commit:

  43eca05b6a3b ("xfrm: Add explicit dev to .xdo_dev_state_{add,delete,free}")

from the ipsec-next tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
index 648a7c618cd1,796e90d741f0..000000000000
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
@@@ -473,12 -474,13 +474,13 @@@ static int ixgbe_ipsec_parse_proto_keys
  
  /**
   * ixgbe_ipsec_check_mgmt_ip - make sure there is no clash with mgmt IP filters
+  * @dev: pointer to net device
   * @xs: pointer to transformer state struct
   **/
- static int ixgbe_ipsec_check_mgmt_ip(struct xfrm_state *xs)
+ static int ixgbe_ipsec_check_mgmt_ip(struct net_device *dev,
+ 				     struct xfrm_state *xs)
  {
- 	struct net_device *dev = xs->xso.real_dev;
 -	struct ixgbe_adapter *adapter = netdev_priv(dev);
 +	struct ixgbe_adapter *adapter = ixgbe_from_netdev(dev);
  	struct ixgbe_hw *hw = &adapter->hw;
  	u32 mfval, manc, reg;
  	int num_filters = 4;
@@@ -559,11 -562,11 +562,11 @@@
   * @xs: pointer to transformer state struct
   * @extack: extack point to fill failure reason
   **/
- static int ixgbe_ipsec_add_sa(struct xfrm_state *xs,
+ static int ixgbe_ipsec_add_sa(struct net_device *dev,
+ 			      struct xfrm_state *xs,
  			      struct netlink_ext_ack *extack)
  {
- 	struct net_device *dev = xs->xso.real_dev;
 -	struct ixgbe_adapter *adapter = netdev_priv(dev);
 +	struct ixgbe_adapter *adapter = ixgbe_from_netdev(dev);
  	struct ixgbe_ipsec *ipsec = adapter->ipsec;
  	struct ixgbe_hw *hw = &adapter->hw;
  	int checked, match, first;
@@@ -752,12 -755,12 +755,12 @@@
  
  /**
   * ixgbe_ipsec_del_sa - clear out this specific SA
+  * @dev: pointer to device to program
   * @xs: pointer to transformer state struct
   **/
- static void ixgbe_ipsec_del_sa(struct xfrm_state *xs)
+ static void ixgbe_ipsec_del_sa(struct net_device *dev, struct xfrm_state *xs)
  {
- 	struct net_device *dev = xs->xso.real_dev;
 -	struct ixgbe_adapter *adapter = netdev_priv(dev);
 +	struct ixgbe_adapter *adapter = ixgbe_from_netdev(dev);
  	struct ixgbe_ipsec *ipsec = adapter->ipsec;
  	struct ixgbe_hw *hw = &adapter->hw;
  	u32 zerobuf[4] = {0, 0, 0, 0};

Content of type "application/pgp-signature" skipped

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ