linux-kernel - Re: [PATCH rtw-next] wifi: rtlwifi: disable ASPM for RTL8723BE with subsystem ID 11ad:1723

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fb0b667a-ebea-4705-9f69-b3bb98399494@aosc.io>
Date: Tue, 22 Apr 2025 14:13:38 +0800
From: Mingcong Bai <jeffbai@...c.io>
To: Ping-Ke Shih <pkshih@...ltek.com>
Cc: Kexy Biscuit <kexybiscuit@...c.io>,
 "stable@...r.kernel.org" <stable@...r.kernel.org>,
 Liangliang Zou <rawdiamondmc@...look.com>,
 "John W. Linville" <linville@...driver.com>,
 Larry Finger <Larry.Finger@...inger.net>,
 "open list:REALTEK WIRELESS DRIVER (rtlwifi family)"
 <linux-wireless@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH rtw-next] wifi: rtlwifi: disable ASPM for RTL8723BE with
 subsystem ID 11ad:1723

Hi Ping-ke,

在 2025/4/22 14:08, Ping-Ke Shih 写道:
> Mingcong Bai <jeffbai@...c.io> wrote:
>>
>> RTL8723BE found on some ASUSTek laptops, such as F441U and X555UQ with
>> subsystem ID 11ad:1723 are known to output large amounts of PCIe AER
>> errors during and after boot up, causing heavy lags and at times lock-ups:
>>
>>    pcieport 0000:00:1c.5: AER: Correctable error message received from 0000:00:1c.5
>>    pcieport 0000:00:1c.5: PCIe Bus Error: severity=Correctable, type=Physical Layer, (Receiver ID)
>>    pcieport 0000:00:1c.5:   device [8086:9d15] error status/mask=00000001/00002000
>>    pcieport 0000:00:1c.5:    [ 0] RxErr
>>
>> Disable ASPM on this combo as a quirk.
>>
>> This patch is a revision of a previous patch (linked below) which
>> attempted to disable ASPM for RTL8723BE on all Intel Skylake and Kaby Lake
>> PCIe bridges. I take a more conservative approach as all known reports
>> point to ASUSTek laptops of these two generations with this particular
>> wireless card.
>>
>> Please note, however, before the rtl8723be finishes probing, the AER
>> errors remained. After the module finishes probing, all AER errors would
>> indeed be eliminated, along with heavy lags, poor network throughput,
>> and/or occasional lock-ups.
>>
>> Cc: <stable@...r.kernel.org>
>> Fixes: 0c8173385e54 ("rtl8192ce: Add new driver")
> 
> This Fixes is weird to me. The subject is RTL8192CE, but you are adding this
> for RTL8723BE. More, at that time, HARDWARE_TYPE_RTL8723BE isn't defined yet.
> 
> This might be more suitable?
> 
> Fixes: a619d1abe20c ("rtlwifi: rtl8723be: Add new driver")

True. Sending v2.

Best Regards,
Mingcong Bai