linux-kernel - Re: [PATCH] nvmet: Fix out-of-bounds access in nvmet_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e38cbd2-c785-4720-8f90-71849f548f4c@nvidia.com>
Date: Tue, 22 Apr 2025 06:33:30 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Richard Weinberger <richard@....at>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"dlemoal@...nel.org" <dlemoal@...nel.org>, "kbusch@...nel.org"
	<kbusch@...nel.org>, Chaitanya Kulkarni <chaitanyak@...dia.com>,
	"sagi@...mberg.me" <sagi@...mberg.me>, "hch@....de" <hch@....de>,
	"upstream+nvme@...ma-star.at" <upstream+nvme@...ma-star.at>
Subject: Re: [PATCH] nvmet: Fix out-of-bounds access in nvmet_enable_port

On 4/18/25 01:02, Richard Weinberger wrote:
> When trying to enable a port that has no transport configured yet,
> nvmet_enable_port() uses NVMF_TRTYPE_MAX (255) to query the transports
> array, causing an out-of-bounds access:
>
> [  106.058694] BUG: KASAN: global-out-of-bounds in nvmet_enable_port+0x42/0x1da
> [  106.058719] Read of size 8 at addr ffffffff89dafa58 by task ln/632
> [...]
> [  106.076026] nvmet: transport type 255 not supported
>
> Since commit 200adac75888, NVMF_TRTYPE_MAX is the default state as configured by
> nvmet_ports_make().
> Avoid this by checking for NVMF_TRTYPE_MAX before proceeding.
>
> Fixes: 200adac75888 ("nvme: Add PCI transport type")
> Signed-off-by: Richard Weinberger<richard@....at>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck