linux-kernel - Re: [tip: x86/microcode] x86/cpu: Help users notice when running old Intel microcode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAc4-eFLp_QeLOUu@gmail.com>
Date: Tue, 22 Apr 2025 08:36:41 +0200
From: Ingo Molnar <mingo@...nel.org>
To: linux-kernel@...r.kernel.org, Dave Hansen <dave.hansen@...ux.intel.com>
Cc: linux-tip-commits@...r.kernel.org,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org
Subject: Re: [tip: x86/microcode] x86/cpu: Help users notice when running old
 Intel microcode


* Ingo Molnar <mingo@...nel.org> wrote:

> > +	if (boot_cpu_data.microcode >= m->driver_data)
> > +		return false;
> 
> Typo:
> 
>   s/microocode
>    /microcode
> 
> I've amended the commit in tip:x86/microcode accordingly, please let me 
> know if this version is fine to you too:

I've also fixed the format of the new X86_BUG_OLD_MICROCODE entry to 
the canonical format used in <asm/cpufeatures.h> (see the delta patch 
below), and pre-merged tip:x86/cpu with fixes/changes by Boris in that 
area. This avoids a tip:master conflict as well. The current commit is:

  4e2c719782a8 x86/cpu: Help users notice when running old Intel microcode

Thanks,

	Ingo

================>
 arch/x86/include/asm/cpufeatures.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
index 4d7ed8bf1770..426c7e8f0158 100644
--- a/arch/x86/include/asm/cpufeatures.h
+++ b/arch/x86/include/asm/cpufeatures.h
@@ -533,6 +533,6 @@
 #define X86_BUG_BHI			X86_BUG( 1*32+ 3) /* "bhi" CPU is affected by Branch History Injection */
 #define X86_BUG_IBPB_NO_RET		X86_BUG( 1*32+ 4) /* "ibpb_no_ret" IBPB omits return target predictions */
 #define X86_BUG_SPECTRE_V2_USER		X86_BUG( 1*32+ 5) /* "spectre_v2_user" CPU is affected by Spectre variant 2 attack between user processes */
-#define X86_BUG_OLD_MICROCODE		X86_BUG(1*32 + 6) /* "old_microcode" CPU has old microcode, it is surely vulnerable to something */
+#define X86_BUG_OLD_MICROCODE		X86_BUG( 1*32+ 6) /* "old_microcode" CPU has old microcode, it is surely vulnerable to something */
 
 #endif /* _ASM_X86_CPUFEATURES_H */