linux-kernel - Re: [PATCH 5/5] staging: iio: adc: ad7816: Simplify channel validation using chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a8aeef26-929d-4601-9eb5-9011d73aa36d@stanley.mountain>
Date: Tue, 22 Apr 2025 09:44:24 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Gabriel Shahrouzi <gshahrouzi@...il.com>
Cc: gregkh@...uxfoundation.org, jic23@...nel.org, lars@...afoo.de,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev, Michael.Hennerich@...log.com,
	sonic.zhang@...log.com, vapier@...too.org,
	skhan@...uxfoundation.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH 5/5] staging: iio: adc: ad7816: Simplify channel
 validation using chip_info

On Sat, Apr 19, 2025 at 09:56:38AM -0400, Gabriel Shahrouzi wrote:
> Refactor the channel validation logic within ad7816_store_channel() to
> leverage the max_channels field previously introduced in the
> ad7816_chip_info structure.
> 
> Signed-off-by: Gabriel Shahrouzi <gshahrouzi@...il.com>

Could you add the ->max_channels struct member here?  This patch would be
easier to review if it had all the ->max_channels information in one place
so we didn't have to jump back to patch 3 to verify that it's correct.

regards,
dan carpenter