linux-kernel - Re: [PATCH v2 RESEND] wifi: iwlwifi: mvm: Add error logging for iwl_finish_nic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c254c3df09fd2c3318f614e76187781be88c6030.camel@sipsolutions.net>
Date: Tue, 22 Apr 2025 09:34:31 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Wentao Liang <vulab@...as.ac.cn>, miriam.rachel.korenblit@...el.com, 
	kvalo@...nel.org
Cc: emmanuel.grumbach@...el.com, golan.ben.ami@...el.com, 
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 RESEND] wifi: iwlwifi: mvm: Add error logging for
 iwl_finish_nic_init()

On Tue, 2025-04-22 at 10:32 +0800, Wentao Liang wrote:
> The function iwl_pci_resume() calls the function iwl_finish_nic_init(),
> but does not check their return values.
> 
> Log a detailed error message with the error code to aid in diagnosing
> root causes if encountering irreparable errors. While this does not fix
> the underlying problem, it assist debugging by making the failure
> visible in logs.
> 
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
> v2: Fix improper code.
> 

Did you though? Especially before _resending_ (whilst a lot of the world
has holidays/vacations too...) you could check patchwork maybe?

Actually, just don't resend unless you see that it's no longer handled
in patchwork?

johannes