linux-kernel - Re: [PATCH v3 2/2] nvme/pci: make PRP list DMA pools per-NUMA-node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6437a1d-8bee-4655-a7bf-e9254b2d881f@samsung.com>
Date: Tue, 22 Apr 2025 13:08:15 +0530
From: Kanchan Joshi <joshi.k@...sung.com>
To: Caleb Sander Mateos <csander@...estorage.com>, Keith Busch
	<kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>, Christoph Hellwig
	<hch@....de>, Sagi Grimberg <sagi@...mberg.me>
Cc: linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] nvme/pci: make PRP list DMA pools per-NUMA-node

On 4/21/2025 10:25 PM, Caleb Sander Mateos wrote:
> +	prp_pools = &dev->prp_pools[numa_node < nr_node_ids ? numa_node : 0];

Numa node values are always in the range [0, nr_node_ids - 1], so is 
this condition "numa_node < nr_node_ids" really required?

The patch looks good to me though.

Reviewed-by: Kanchan Joshi <joshi.k@...sung.com>