linux-kernel - Re: [External] Re: [PATCH v3] serial: 8250: fix panic due to PSLVERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAdI0SH-mz1Uf4d-@smile.fi.intel.com>
Date: Tue, 22 Apr 2025 10:44:17 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: yunhui cui <cuiyunhui@...edance.com>
Cc: ilpo.jarvinen@...ux.intel.com, gregkh@...uxfoundation.org,
	jirislaby@...nel.org, john.ogness@...utronix.de, pmladek@...e.com,
	arnd@...db.de, namcao@...utronix.de, benjamin.larsson@...exis.eu,
	schnelle@...ux.ibm.com, heikki.krogerus@...ux.intel.com,
	markus.mayer@...aro.org, tim.kryger@...aro.org,
	matt.porter@...aro.org, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org
Subject: Re: [External] Re: [PATCH v3] serial: 8250: fix panic due to PSLVERR

On Mon, Apr 21, 2025 at 10:55:05AM +0800, yunhui cui wrote:
> On Mon, Apr 14, 2025 at 4:47 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > On Mon, Apr 14, 2025 at 11:14:50AM +0800, Yunhui Cui wrote:

...

> > This patch seems need split to three. See below.

...

> > > --- a/drivers/tty/serial/8250/8250_dw.c
> > > +++ b/drivers/tty/serial/8250/8250_dw.c
> >
> > Changes here deserve the separate patch (patch 1).
> 
> Splitting into a patchset is fine. What does "patch 1" refer to here?

A new series out of three patches, the above change looks good to be placed in
patch 1/3 in that _new_ series. Same for patch 2/3 and 3/3 below.

...

> > > +     /*
> > > +      * Serial_in(p, UART_RX) should be under port->lock, but we can't add
> >
> > serial_in()
> 
> Okay.
> 
> > > +      * it to avoid AA deadlock as we're unsure if serial_out*(...UART_LCR)
> > > +      * is under port->lock.
> > > +      */
> > > +     lockdep_assert_held_once(&p->lock);

...

> > > +     uart_port_lock_irqsave(port, &flags);
> >
> > And one patch (patch 3) about locking.
> 
> Okay.

-- 
With Best Regards,
Andy Shevchenko