linux-kernel - Re: [PATCH 1/2] bus: hisi_lpc: remove unused head file in hisi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAdMNb8n_wr5PwyQ@smile.fi.intel.com>
Date: Tue, 22 Apr 2025 10:58:45 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Pei Xiao <xiaopeitux@...mail.com>
Cc: linux-kernel@...r.kernel.org, f.fangjian@...wei.com, robh@...nel.org,
	john.g.garry@...cle.com, xuwei5@...ilicon.com,
	Pei Xiao <xiaopei01@...inos.cn>
Subject: Re: [PATCH 1/2] bus: hisi_lpc: remove unused head file in hisi_lpc.c

On Mon, Apr 21, 2025 at 10:06:28AM +0800, Pei Xiao wrote:
> 在 2025/4/19 23:22, Andy Shevchenko 写道:
> > On Fri, Apr 18, 2025 at 04:51:23PM +0800, xiaopeitux@...mail.com wrote:

...

> >> linux/console.h,linux/io.h,linux/pci.h,linux/slab.h
> >> are not used, this patch removes it.
> > Definitely you haven't tested this...
> 
> Sorry for that,I have tested in ARM64 platform, have no build problem,sorry for that!

Okay, but you need to follow IWYU principle. io.h is definitely used in this
file.

-- 
With Best Regards,
Andy Shevchenko