linux-kernel - Re: [PATCH] xfs: add tunable threshold parameter for triggering zone GC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vtbzasrb6cx4ysofaeyjus75ptnqrydm24xw7btzeiokqueey3@qamjjgwyubml>
Date: Tue, 22 Apr 2025 09:59:52 +0200
From: Carlos Maiolino <cem@...nel.org>
To: hch <hch@....de>
Cc: Guenter Roeck <linux@...ck-us.net>, 
	Hans Holmberg <Hans.Holmberg@....com>, Dave Chinner <david@...morbit.com>, 
	"Darrick J . Wong" <djwong@...nel.org>, "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xfs: add tunable threshold parameter for triggering zone
 GC

On Tue, Apr 22, 2025 at 08:01:37AM +0200, hch wrote:
> On Mon, Apr 21, 2025 at 10:57:31PM -0700, Guenter Roeck wrote:
> >> free should be floored to zero, i.e.
> >>
> >> 	free = min(0, xfs_estimate_freecounter(mp, XC_FREE_RTEXTENTS));
> >>
> >
> > Do you mean max, maybe ?
> 
> Yes, sorry.
> 
> Also if you want the work taken off your hands I can prepare a patch
> as well, I just don't want to do that without approval from the
> original author.

Just noticed it, I shouldn't read emails backwards on time :)
I had the same thoughts as hch though. But giving Guenter's last message...

hch, do you want to write a patch for that or should I?

btw, Guenter, I still plan to work on a generic mult_frac() to properly fix
this. Could you please share a reproducer for your case so I can test it on the
same architectures you're doing so? Hopefully it can be cross compiled?