linux-kernel - Re: [PATCH] irqchip/sg2042-msi: Fix wrong type cast in sg2044_msi_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB226200249253571617B14BDBFEBB2@MA0P287MB2262.INDP287.PROD.OUTLOOK.COM>
Date: Tue, 22 Apr 2025 09:46:33 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Inochi Amaoto <inochiama@...il.com>, Thomas Gleixner <tglx@...utronix.de>
Cc: linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] irqchip/sg2042-msi: Fix wrong type cast in
 sg2044_msi_irq_ack


On 2025/4/22 8:38, Inochi Amaoto wrote:
> The type cast in sg2044_msi_irq_ack lost __iomem attribute,
> which make the pointer type incorrect.
>
> Add the miss "__iomem" attribute to fix it.
>
> Fixes: e96b93a97c90 ("irqchip/sg2042-msi: Add the Sophgo SG2044 MSI interrupt controller")
> Signed-off-by: Inochi Amaoto <inochiama@...il.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202504211251.B3aesulq-lkp@intel.com/
> ---
>   drivers/irqchip/irq-sg2042-msi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sg2042-msi.c b/drivers/irqchip/irq-sg2042-msi.c
> index 8a83c690b760..a3e2a26d8495 100644
> --- a/drivers/irqchip/irq-sg2042-msi.c
> +++ b/drivers/irqchip/irq-sg2042-msi.c
> @@ -98,7 +98,7 @@ static void sg2044_msi_irq_ack(struct irq_data *d)
>   {
>   	struct sg204x_msi_chipdata *data = irq_data_get_irq_chip_data(d);
>
> -	writel(0, (u32 *)data->reg_clr + d->hwirq);
> +	writel(0, (u32 __iomem *)data->reg_clr + d->hwirq);
>   	irq_chip_ack_parent(d);
>   }
>
> --
> 2.49.0

Reviewed-by: Chen Wang <unicorn_wang@...look.com>

Thanks,

Chen