linux-kernel - Re: [PATCH v2 0/5] mm/vmalloc.c: code cleanup and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAdY9o8TeNi8G8bN@pc638.lan>
Date: Tue, 22 Apr 2025 10:53:10 +0200
From: Uladzislau Rezki <urezki@...il.com>
To: Baoquan He <bhe@...hat.com>
Cc: linux-mm@...ck.org, akpm@...ux-foundation.org, urezki@...il.com,
	shivankg@....com, vishal.moola@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/5] mm/vmalloc.c: code cleanup and improvements

On Sat, Apr 19, 2025 at 06:36:48AM +0800, Baoquan He wrote:
> These were made from code inspection in mm/vmalloc.c.
> 
> v1->v2:
> =======
> - In patch 3:
>   - made change to improve code according to Uladzislau's suggestion;
>   - use WRITE_ONCE() to assign the value to vn->pool[i].len finally,
>     according to Shivank's suggestion.
> In patch 5:
>   - add back the WARN_ON_ONCE() on returned value from va_clip()
>     invocation, and also add back the code comment. These are pointed
>     out by Uladzislau. 
> 
> - Add reviewers' tag from Uladzislau, Shivank and Vishal. And I only add
>   Shivank's tag in patch 1, 2, 4 according to his comment because patch 3
>   and 5 are changed in v2.
> 
> Baoquan He (5):
>   mm/vmalloc.c: change purge_ndoes as local static variable
>   mm/vmalloc.c: find the vmap of vmap_nodes in reverse order
>   mm/vmalloc.c: optimize code in decay_va_pool_node() a little bit
>   mm/vmalloc: optimize function vm_unmap_aliases()
>   mm/vmalloc.c: return explicit error value in alloc_vmap_area()
> 
>  mm/vmalloc.c | 61 ++++++++++++++++++++++++----------------------------
>  1 file changed, 28 insertions(+), 33 deletions(-)
> 
> -- 
> 2.41.0
> 
LGTM for whole series:

Reviewed-by: Uladzislau Rezki (Sony) <urezki@...il.com>

--
Uladzislau Rezki