linux-kernel - Re: [PATCH v2 RESEND] brcm80211: fmac: Add error handling for brcmf_usb_dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4de3f9d-5748-4969-98c6-7d17395eef4b@web.de>
Date: Tue, 22 Apr 2025 12:43:19 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: vulab@...as.ac.cn, brcm80211-dev-list.pdl@...adcom.com,
 brcm80211@...ts.linux.dev, linux-wireless@...r.kernel.org
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
 Arend van Spriel <arend.vanspriel@...adcom.com>,
 Christophe Jaillet <christophe.jaillet@...adoo.fr>,
 Erick Archer <erick.archer@...look.com>, Jacobe Zang
 <jacobe.zang@...ion.com>, Kalle Valo <kvalo@...nel.org>,
 Sebastian Reichel <sebastian.reichel@...labora.com>
Subject: Re: [PATCH v2 RESEND] brcm80211: fmac: Add error handling for
 brcmf_usb_dl_writeimage()

…
> brcmf_usb_dl_cmd() but dose not check its return value. The
…

Please avoid typos in such a change description.


> Add error handling for brcmf_usb_dl_cmd() to jump to error
> handling path if the brcmf_usb_dl_cmd() fails and the
> 'state.state' and the 'state.bytes' are uninitialized.

This wording is improvable.


> Improve the error message to report more detailed error
> information.

Please offer such an adjustment by a separate update step.
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.15-rc3#n81

Regards,
Markus