linux-kernel - RE: [PATCH v3 0/2] Add support for LT3074 low voltage linear regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH0PR03MB69384B9ADED36F0E0EC5C73C8EBB2@PH0PR03MB6938.namprd03.prod.outlook.com>
Date: Tue, 22 Apr 2025 10:09:40 +0000
From: "Encarnacion, Cedric justine" <Cedricjustine.Encarnacion@...log.com>
To: Guenter Roeck <linux@...ck-us.net>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Jean Delvare <jdelvare@...e.com>,
        Jonathan Corbet <corbet@....net>,
        Delphine
 CC Chiu <Delphine_CC_Chiu@...ynn.com>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>
Subject: RE: [PATCH v3 0/2] Add support for LT3074 low voltage linear
 regulator

> From: Guenter Roeck <groeck7@...il.com> On Behalf Of Guenter Roeck
> Sent: Monday, April 21, 2025 9:23 PM
> To: Encarnacion, Cedric justine <Cedricjustine.Encarnacion@...log.com>; Rob
> Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor
> Dooley <conor+dt@...nel.org>; Jean Delvare <jdelvare@...e.com>; Jonathan
> Corbet <corbet@....net>; Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
> Cc: devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> hwmon@...r.kernel.org; linux-doc@...r.kernel.org; linux-i2c@...r.kernel.org
> Subject: Re: [PATCH v3 0/2] Add support for LT3074 low voltage linear regulator
> 
> [External]
> 
> On 4/21/25 05:18, Cedric Encarnacion wrote:
> > Introduce hardware monitoring and regulator support for LT3074. The
> > component is an ultrafast, ultralow noise 3A, 5.5V dropout linear
> > regulator with a PMBus serial interface that allows telemetry for
> > input/output voltage, output current, and die temperature. It has a
> > single channel and requires a bias voltage which can be monitored via
> > manufacturer-specific registers.
> >
> > Signed-off-by: Cedric Encarnacion
> > <cedricjustine.encarnacion@...log.com>
> > ---
> > Changes in v3:
> > -
> >   * Non-nested dt-binding regulator support.
> >   * PMBUS_REGULATOR_ONE("vout") ->
> PMBUS_REGULATOR_ONE("regulator").
> >     New macro needs node-name to be matched.
> >
> 
> Does that mean we can (and maybe should) drop the name parameter of that
> macro ?
> 
> This isn't affecting this patch. If needed I'll do that separately.
> Just asking.

This is used by regulator_desc->of_match to match a node name in dt. By
dropping the name, does this mean the of_match won't be assigned, or
of_match="some-default-regulator-name"? I did some tests, and it appears
the regulators dt properties can only be parsed when the name parameter
exists, and name parameter == node-name. I have tried simply removing the
of_match assignment from the regulator_desc macro, but it does not work in
my case.

Best regards,
Cedric

> > - Link to v2:
> > https://urldefense.com/v3/__https://lore.kernel.org/r/20250225-upstrea
> > m-lt3074-v2-0-
> 18ad10ba542e@...log.com__;!!A3Ni8CS0y2Y!7jXNBOqw7P6dNnjZ
> > TKrDqezkv8BSgZf9ZEeOfTvvbXEP3IfjL8UCdzIWjAIMFy--UJKsE_bztdArzpX5joZt35
> > NsPf0$
> >
> > Changes in v2:
> >   * Separated dt-binding for LT3074.
> >   * Added __maybe_unused attribute to of_device_id. This addresses kernel
> >     test robot warning.
> >   * Added entry to MAINTAINERS.
> >
> > - Link to v1:
> > https://urldefense.com/v3/__https://lore.kernel.org/r/20250124-upstrea
> > m-lt3074-v1-0-
> 7603f346433e@...log.com__;!!A3Ni8CS0y2Y!7jXNBOqw7P6dNnjZ
> > TKrDqezkv8BSgZf9ZEeOfTvvbXEP3IfjL8UCdzIWjAIMFy--UJKsE_bztdArzpX5joZt1h
> > Q_Vuk$
> >
> > ---
> > Cedric Encarnacion (2):
> >        dt-bindings: hwmon: pmbus: add lt3074
> >        hwmon: (pmbus/lt3074): add support for lt3074
> >
> >   .../bindings/hwmon/pmbus/adi,lt3074.yaml           |  50 +++++++++
> >   Documentation/hwmon/index.rst                      |   1 +
> >   Documentation/hwmon/lt3074.rst                     |  72 ++++++++++++
> >   MAINTAINERS                                        |   9 ++
> >   drivers/hwmon/pmbus/Kconfig                        |  18 +++
> >   drivers/hwmon/pmbus/Makefile                       |   1 +
> >   drivers/hwmon/pmbus/lt3074.c                       | 122 +++++++++++++++++++++
> >   7 files changed, 273 insertions(+)
> > ---
> > base-commit: 86d264b68309d9f9804db4079642b98104ca15df
> > change-id: 20250124-upstream-lt3074-123384246e0b
> >
> > Best regards,