linux-kernel - Re: [PATCH v3] mm: alloc_pages_bulk: support both simple and full-featured API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd6db77d-fcb4-44d9-8f1b-61749b411c33@huawei.com>
Date: Tue, 22 Apr 2025 19:22:50 +0800
From: Yunsheng Lin <linyunsheng@...wei.com>
To: Leon Romanovsky <leon@...nel.org>, Andrew Morton
	<akpm@...ux-foundation.org>
CC: Yishai Hadas <yishaih@...dia.com>, Jason Gunthorpe <jgg@...pe.ca>, Shameer
 Kolothum <shameerali.kolothum.thodi@...wei.com>, Kevin Tian
	<kevin.tian@...el.com>, Alex Williamson <alex.williamson@...hat.com>, Chris
 Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>, David Sterba
	<dsterba@...e.com>, Gao Xiang <xiang@...nel.org>, Chao Yu <chao@...nel.org>,
	Yue Hu <zbestahu@...il.com>, Jeffle Xu <jefflexu@...ux.alibaba.com>, Sandeep
 Dhavale <dhavale@...gle.com>, Chuck Lever <chuck.lever@...cle.com>, Jeff
 Layton <jlayton@...nel.org>, Neil Brown <neilb@...e.de>, Olga Kornievskaia
	<okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey
	<tom@...pey.com>, Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu
	<mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>,
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>, Yonghong
 Song <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, KP
 Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo
	<haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, Jesper Dangaard Brouer
	<hawk@...nel.org>, Ilias Apalodimas <ilias.apalodimas@...aro.org>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
	<horms@...nel.org>, Trond Myklebust <trondmy@...nel.org>, Anna Schumaker
	<anna@...nel.org>, Luiz Capitulino <luizcap@...hat.com>, Mel Gorman
	<mgorman@...hsingularity.net>, <kvm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <virtualization@...ts.linux.dev>,
	<linux-btrfs@...r.kernel.org>, <linux-erofs@...ts.ozlabs.org>,
	<linux-mm@...ck.org>, <linux-nfs@...r.kernel.org>,
	<linux-trace-kernel@...r.kernel.org>, <bpf@...r.kernel.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH v3] mm: alloc_pages_bulk: support both simple and
 full-featured API

On 2025/4/20 19:21, Leon Romanovsky wrote:

...

>>
>> diff --git a/drivers/vfio/pci/mlx5/cmd.c b/drivers/vfio/pci/mlx5/cmd.c
>> index 11eda6b207f1..fb094527715f 100644
>> --- a/drivers/vfio/pci/mlx5/cmd.c
>> +++ b/drivers/vfio/pci/mlx5/cmd.c
>> @@ -446,8 +446,6 @@ static int mlx5vf_add_migration_pages(struct mlx5_vhca_data_buffer *buf,
>>  		if (ret)
>>  			goto err_append;
>>  		buf->allocated_length += filled * PAGE_SIZE;
>> -		/* clean input for another bulk allocation */
>> -		memset(page_list, 0, filled * sizeof(*page_list));
>>  		to_fill = min_t(unsigned int, to_alloc,
>>  				PAGE_SIZE / sizeof(*page_list));
> 
> If it is possible, let's drop this hunk to reduce merge conflicts.
> The whole mlx5vf_add_migration_pages() is planned to be rewritten.
> https://lore.kernel.org/linux-rdma/076a3991e663fe07c1a5395f5805c514b63e4d94.1744825142.git.leon@kernel.org/

It seems mlx5vf_add_migration_pages() is changed to use the pattern
of passing 'page_array + allocated' and 'nr_pages - allocated' in the
above patch, so I think it is ok to drop the above hunk.

Hi, Andrew
Do you want me to resend this patch without the above hunk or it is
possible that you can drop the above hunk when committing if there
is no other comment need fixing?

> 
> Thanks
> 
>