linux-kernel - Re: [PATCH v5] brcm80211: fmac: Add error log in brcmf_usb_dl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <15f43f65-2f2f-4fc6-8210-60afdd9be004@broadcom.com>
Date: Tue, 22 Apr 2025 13:39:27 +0200
From: Arend van Spriel <arend.vanspriel@...adcom.com>
To: Wentao Liang <vulab@...as.ac.cn>, kvalo@...nel.org
Cc: linux-wireless@...r.kernel.org, brcm80211@...ts.linux.dev,
 brcm80211-dev-list.pdl@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] brcm80211: fmac: Add error log in brcmf_usb_dl_cmd()



On 4/22/2025 8:59 AM, Wentao Liang wrote:
> In brcmf_usb_dl_cmd(), the error logging is not enough to describe
> the error state. And some caller of the brcmf_usb_dl_cmd() does not
> handle its error. An error log in brcmf_usb_dl_cmd() is needed to
> prevent silent failure.
> 
> Add error handling in brcmf_usb_dl_cmd() to log the command id and
> error code in the brcmf_usb_dl_cmd() fails. In this way, every
> invocation of the function logs a message upon failure.

Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
> v5: Remove finalize label.
> v4: Fix spelling problem.
> v3: Change patch name and comment. Move error log into brcmf_usb_dl_cmd().
> v2: Remove redundant bailing out code.
> 
>   .../broadcom/brcm80211/brcmfmac/usb.c         | 23 +++++++++++++------
>   1 file changed, 16 insertions(+), 7 deletions(-)