linux-kernel - Re: [PATCH 0/6] arm64: dts: qcom: qcs615: enable remoteprocs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <174541475836.315268.1404586813028809700.robh@kernel.org>
Date: Wed, 23 Apr 2025 08:37:44 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Lijuan Gao <quic_lijuang@...cinc.com>
Cc: linux-kernel@...r.kernel.org, 
 Mathieu Poirier <mathieu.poirier@...aro.org>, linux-arm-msm@...r.kernel.org, 
 Kyle Deng <quic_chunkaid@...cinc.com>, Conor Dooley <conor+dt@...nel.org>, 
 Bjorn Andersson <andersson@...nel.org>, linux-remoteproc@...r.kernel.org, 
 kernel@...cinc.com, 
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, devicetree@...r.kernel.org, 
 Konrad Dybcio <konradybcio@...nel.org>
Subject: Re: [PATCH 0/6] arm64: dts: qcom: qcs615: enable remoteprocs -
 ADSP and CDSP


On Wed, 23 Apr 2025 17:17:36 +0800, Lijuan Gao wrote:
> Enable the remote processor PAS loader for QCS615 ADSP and CDSP
> processors. This allows different platforms/architectures to control
> (power on, load firmware, power off) those remote processors while
> abstracting the hardware differences. Additionally, and add a PIL region
> in IMEM so that post mortem debug tools can collect ramdumps.
> 
> Signed-off-by: Lijuan Gao <quic_lijuang@...cinc.com>
> ---
> Kyle Deng (1):
>       arm64: dts: qcom: qcs615: Add mproc node for SEMP2P
> 
> Lijuan Gao (5):
>       dt-bindings: remoteproc: qcom,sm8150-pas: Document QCS615 remoteproc
>       dt-bindings: soc: qcom: add qcom,qcs615-imem compatible
>       arm64: dts: qcom: qcs615: Add IMEM and PIL info region
>       arm64: dts: qcom: qcs615: add ADSP and CDSP nodes
>       arm64: dts: qcom: qcs615-ride: enable remoteprocs
> 
>  .../bindings/remoteproc/qcom,sm8150-pas.yaml       |  59 ++++---
>  .../devicetree/bindings/sram/qcom,imem.yaml        |   1 +
>  arch/arm64/boot/dts/qcom/qcs615-ride.dts           |  10 ++
>  arch/arm64/boot/dts/qcom/qcs615.dtsi               | 179 +++++++++++++++++++++
>  4 files changed, 225 insertions(+), 24 deletions(-)
> ---
> base-commit: f660850bc246fef15ba78c81f686860324396628
> change-id: 20250416-add_qcs615_remoteproc_support-61ddab556c4e
> 
> Best regards,
> --
> Lijuan Gao <quic_lijuang@...cinc.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit f660850bc246fef15ba78c81f686860324396628

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250423-add_qcs615_remoteproc_support-v1-0-a94fe8799f14@...cinc.com:

arch/arm64/boot/dts/qcom/qcs615-ride.dtb: qcom,smp2p-adsp (qcom,smp2p): 'qcom,sleepstate-in', 'qcom,smp2p-rdbg2-in', 'qcom,smp2p-rdbg2-out', 'sleepstate-out' do not match any of the regexes: '^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap|wlan-ap-to-wpss|wlan-wpss-to-ap$', '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,smp2p.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: qcom,smp2p-adsp (qcom,smp2p): {'compatible': ['qcom,smp2p'], 'qcom,smem': [443, 429], 'interrupts': [[0, 172, 1]], 'mboxes': [[30, 26]], 'qcom,ipc': [[31, 0, 26]], 'qcom,local-pid': 0, 'qcom,remote-pid': 2, 'master-kernel': {'qcom,entry-name': ['master-kernel'], '#qcom,smem-state-cells': 1, 'phandle': 218}, 'slave-kernel': {'qcom,entry-name': ['slave-kernel'], 'interrupt-controller': True, '#interrupt-cells': 2, 'phandle': 216}, 'sleepstate-out': {'qcom,entry-name': ['sleepstate'], '#qcom,smem-state-cells': 1}, 'qcom,sleepstate-in': {'qcom,entry-name': ['sleepstate_see'], 'interrupt-controller': True, '#interrupt-cells': 2}, 'qcom,smp2p-rdbg2-out': {'qcom,entry-name': ['rdbg'], '#qcom,smem-state-cells': 1}, 'qcom,smp2p-rdbg2-in': {'qcom,entry-name': ['rdbg'], 'interrupt-controller': True, '#interrupt-cells': 2}, '$nodename': ['qcom,smp2p-adsp']} is valid under each of {'required': ['qcom,ipc']}, {'required': ['mboxes']}
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,smp2p.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: qcom,smp2p-cdsp (qcom,smp2p): 'qcom,smp2p-rdbg5-in', 'qcom,smp2p-rdbg5-out' do not match any of the regexes: '^master-kernel|slave-kernel|ipa-ap-to-modem|ipa-modem-to-ap|wlan-ap-to-wpss|wlan-wpss-to-ap$', '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,smp2p.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: qcom,smp2p-cdsp (qcom,smp2p): {'compatible': ['qcom,smp2p'], 'qcom,smem': [94, 432], 'interrupts': [[0, 576, 1]], 'mboxes': [[30, 6]], 'qcom,ipc': [[31, 0, 6]], 'qcom,local-pid': 0, 'qcom,remote-pid': 5, 'master-kernel': {'qcom,entry-name': ['master-kernel'], '#qcom,smem-state-cells': 1, 'phandle': 200}, 'slave-kernel': {'qcom,entry-name': ['slave-kernel'], 'interrupt-controller': True, '#interrupt-cells': 2, 'phandle': 198}, 'qcom,smp2p-rdbg5-out': {'qcom,entry-name': ['rdbg'], '#qcom,smem-state-cells': 1}, 'qcom,smp2p-rdbg5-in': {'qcom,entry-name': ['rdbg'], 'interrupt-controller': True, '#interrupt-cells': 2}, '$nodename': ['qcom,smp2p-cdsp']} is valid under each of {'required': ['qcom,ipc']}, {'required': ['mboxes']}
	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,smp2p.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: remoteproc-cdsp@...0000 (qcom,qcs615-cdsp-pas): interrupt-names:2: 'ready' was expected
	from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm8150-pas.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: remoteproc-cdsp@...0000 (qcom,qcs615-cdsp-pas): interrupt-names:3: 'handover' was expected
	from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm8150-pas.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: remoteproc-cdsp@...0000 (qcom,qcs615-cdsp-pas): Unevaluated properties are not allowed ('glink-edge', 'qcom,smem-state-names', 'qcom,smem-states' were unexpected)
	from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm8150-pas.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: syscon@...0000c (syscon): compatible: ['syscon'] is too short
	from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: remoteproc-adsp@...00000 (qcom,qcs615-adsp-pas): interrupt-names:2: 'ready' was expected
	from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm8150-pas.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: remoteproc-adsp@...00000 (qcom,qcs615-adsp-pas): interrupt-names:3: 'handover' was expected
	from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm8150-pas.yaml#
arch/arm64/boot/dts/qcom/qcs615-ride.dtb: remoteproc-adsp@...00000 (qcom,qcs615-adsp-pas): Unevaluated properties are not allowed ('glink-edge', 'qcom,smem-state-names', 'qcom,smem-states' were unexpected)
	from schema $id: http://devicetree.org/schemas/remoteproc/qcom,sm8150-pas.yaml#