linux-kernel - Re: [PATCH] usb: typec: ucsi: fix Clang -Wsign-conversion warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAjua0rWkHO4H6Rj@kuha.fi.intel.com>
Date: Wed, 23 Apr 2025 16:43:07 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Qasim Ijaz <qasdev00@...il.com>
Cc: gregkh@...uxfoundation.org, lumag@...nel.org, pooja.katiyar@...el.com,
	diogo.ivo@...nico.ulisboa.pt, madhu.m@...el.com,
	saranya.gopal@...el.com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] usb: typec: ucsi: fix Clang -Wsign-conversion warning

On Tue, Apr 22, 2025 at 02:47:17PM +0100, Qasim Ijaz wrote:
> debugfs.c emits the following warnings when compiling with the -Wsign-conversion flag with clang 15:
> 
> drivers/usb/typec/ucsi/debugfs.c:58:27: warning: implicit conversion changes signedness: 'int' to 'u32' (aka 'unsigned int') [-Wsign-conversion]
>                 ucsi->debugfs->status = ret;
>                                       ~ ^~~
> drivers/usb/typec/ucsi/debugfs.c:71:25: warning: implicit conversion changes signedness: 'u32' (aka 'unsigned int') to 'int' [-Wsign-conversion]
>                 return ucsi->debugfs->status;
>                 ~~~~~~ ~~~~~~~~~~~~~~~^~~~~~
>                 
> During ucsi_cmd() we see:
> 
> 	if (ret < 0) {
> 		ucsi->debugfs->status = ret;
> 		return ret;
> 	}
> 	
> But "status" is u32 meaning unsigned wrap-around occurs when assigning a value which is < 0 to it, this obscures the real status.
> 
> To fix this make the "status" of type int since ret is also of type int.
> 
> Fixes: df0383ffad64 ("usb: typec: ucsi: Add debugfs for ucsi commands")
> Cc: stable@...r.kernel.org
> Signed-off-by: Qasim Ijaz <qasdev00@...il.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/ucsi/ucsi.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 3a2c1762bec1..525d28160413 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -432,7 +432,7 @@ struct ucsi_debugfs_entry {
>  		u64 low;
>  		u64 high;
>  	} response;
> -	u32 status;
> +	int status;
>  	struct dentry *dentry;
>  };
>  
> -- 
> 2.39.5

-- 
heikki