linux-kernel - RE: [PATCH v6 5/6] dmaengine: sh: rz-dmac: Add RZ/V2H(P) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYCSPRMB000932621B754A38F0FCBF8CC2BA2@TYCSPRMB0009.jpnprd01.prod.outlook.com>
Date: Wed, 23 Apr 2025 13:46:46 +0000
From: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
To: Vinod Koul <vkoul@...nel.org>
CC: Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm
	<magnus.damm@...il.com>, Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>, Biju Das
	<biju.das.jz@...renesas.com>, "dmaengine@...r.kernel.org"
	<dmaengine@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>, "tglx@...utronix.de"
	<tglx@...utronix.de>
Subject: RE: [PATCH v6 5/6] dmaengine: sh: rz-dmac: Add RZ/V2H(P) support

Hi Vinod,

Thanks for your feedback!

> From: Vinod Koul <vkoul@...nel.org>
> Sent: 23 April 2025 14:13
> Subject: Re: [PATCH v6 5/6] dmaengine: sh: rz-dmac: Add RZ/V2H(P) support
> 
> On 22-04-25, 18:39, Fabrizio Castro wrote:
> > The DMAC IP found on the Renesas RZ/V2H(P) family of SoCs is
> > similar to the version found on the Renesas RZ/G2L family of
> > SoCs, but there are some differences:
> > * It only uses one register area
> > * It only uses one clock
> > * It only uses one reset
> > * Instead of using MID/IRD it uses REQ No
> > * It is connected to the Interrupt Control Unit (ICU)
> > * On the RZ/G2L there is only 1 DMAC, on the RZ/V2H(P) there are 5
> >
> > Add specific support for the Renesas RZ/V2H(P) family of SoC by
> > tackling the aforementioned differences.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@...esas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> > v5->v6:
> > * Collected tags.
> > v4->v5:
> > * Reused RZ/G2L cell specification (with REQ No in place of MID/RID).
> > * Dropped ACK No.
> > * Removed mid_rid/req_no/ack_no union and reused mid_rid for REQ No.
> > * Other small improvements.
> > v3->v4:
> > * Fixed an issue with mid_rid/req_no/ack_no initialization
> > v2->v3:
> > * Dropped change to Kconfig.
> > * Replaced rz_dmac_type with has_icu flag.
> > * Put req_no and ack_no in an anonymous struct, nested under an
> >   anonymous union with mid_rid.
> > * Dropped data field of_rz_dmac_match[], and added logic to determine
> >   value of has_icu flag from DT parsing.
> > v1->v2:
> > * Switched to new macros for minimum values.
> > ---
> >  drivers/dma/sh/rz-dmac.c | 81 ++++++++++++++++++++++++++++++++++++----
> >  1 file changed, 74 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c
> > index d7a4ce28040b..1f687b08d6b8 100644
> > --- a/drivers/dma/sh/rz-dmac.c
> > +++ b/drivers/dma/sh/rz-dmac.c
> > @@ -14,6 +14,7 @@
> >  #include <linux/dmaengine.h>
> >  #include <linux/interrupt.h>
> >  #include <linux/iopoll.h>
> > +#include <linux/irqchip/irq-renesas-rzv2h.h>
> 
> This does not exist for me or in the patches that was sent to me. I have
> dropped this series due to build failure after picking up dmaengine
> patches
> 
> drivers/dma/sh/rz-dmac.c:17:10: fatal error: linux/irqchip/irq-renesas-rzv2h.h: No such file or
> directory

Sorry about that.

This DMA to work needs access to some ICU features, which are part of this series,
however somehow I didn't send you those patches. Apologies.

I'll send a new version of this series shortly (because there are some minor
improvements to the dt-bindings that I would like to make, to address the last
comments from Geert. It should all be good to go after that as everything has
been reviewed by the relevant maintainers already), and I'll make sure to send
the whole series to you.

I am assuming you'll also be taking the ICU related changes as suggested by
Thomas:
https://lore.kernel.org/linux-renesas-soc/87a5ajk7hr.ffs@tglx/

Thanks!

Cheers,
Fab

> 
> --
> ~Vinod