linux-kernel - Re: [PATCH v5 3/5] arm64: dts: qcom: Add initial support for MSM8937

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <790a0b7537e0b82b70bc4b32612ecee6@mainlining.org>
Date: Wed, 23 Apr 2025 16:46:03 +0200
From: barnabas.czeman@...nlining.org
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Michael Turquette
 <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Stephan Gerhold <stephan@...hold.net>,
 Otto Pflüger <otto.pflueger@...cue.de>, Linus Walleij
 <linus.walleij@...aro.org>, Lee Jones <lee@...nel.org>, Joerg Roedel
 <joro@...tes.org>, Will Deacon <will@...nel.org>, Robin Murphy
 <robin.murphy@....com>, Konrad Dybcio <konradybcio@...nel.org>, Rob Clark
 <robdclark@...il.com>, Sean Paul <sean@...rly.run>, Abhinav Kumar
 <quic_abhinavk@...cinc.com>, Marijn Suijten <marijn.suijten@...ainline.org>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Maarten
 Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, Dmitry
 Baryshkov <lumag@...nel.org>, Adam Skladowski <a_skl39@...tonmail.com>,
 Sireesh Kodali <sireeshkodali@...tonmail.com>, Srinivas Kandagatla
 <srini@...nel.org>, linux-arm-msm@...r.kernel.org,
 linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 iommu@...ts.linux.dev, dri-devel@...ts.freedesktop.org,
 freedreno@...ts.freedesktop.org, phone-devel@...r.kernel.org,
 ~postmarketos/upstreaming@...ts.sr.ht, linux@...nlining.org, Dang Huynh
 <danct12@...eup.net>
Subject: Re: [PATCH v5 3/5] arm64: dts: qcom: Add initial support for MSM8937

On 2025-04-23 16:03, Konrad Dybcio wrote:
> On 4/21/25 10:18 PM, Barnabás Czémán wrote:
>> From: Dang Huynh <danct12@...eup.net>
>> 
>> Add initial support for MSM8937 SoC.
>> 
>> Signed-off-by: Dang Huynh <danct12@...eup.net>
>> Co-developed-by: Barnabás Czémán <barnabas.czeman@...nlining.org>
>> Signed-off-by: Barnabás Czémán <barnabas.czeman@...nlining.org>
>> ---
> 
> [...]
> 
>> +			tsens_base1: base1@1d8 {
>> +				reg = <0x1d8 1>;
> 
> The size part should be hex too
> 
> [...]
> 
>> +				wcss-wlan2-pins {
>> +					pins = "gpio76";
>> +					function = "wcss_wlan2";
>> +					drive-strength = <6>;
>> +					bias-pull-up;
>> +
>> +				};
>> +
>> +			};
> 
> random newline /\
> 
> [...]
> 
>> +		mdss: display-subsystem@...0000 {
>> +			compatible = "qcom,mdss";
>> +			reg = <0x01a00000 0x1000>,
>> +			      <0x01ab0000 0x1040>;
> 
> The latter region is 0x3000-long
> 
>> +			reg-names = "mdss_phys", "vbif_phys";
> 
> Please make reg-names a vertical list too
> 
> [...]
> 
> 
>> +		gpu: gpu@...0000 {
>> +			compatible = "qcom,adreno-505.0", "qcom,adreno";
>> +			reg = <0x1c00000 0x40000>;
> 
> Please pad the address part to 8 hex digits
> 
> [...]
> 
>> +			gpu_opp_table: opp-table {
>> +				compatible = "operating-points-v2";
>> +
>> +				opp-19200000 {
>> +					opp-hz = /bits/ 64 <19200000>;
>> +					opp-supported-hw = <0xff>;
> 
> The comment from the previous revision still stands
If i remove opp-supported-hw i will got -22 EINVAL messages and the opp 
will be not fine.
> 
> Konrad