linux-kernel - Re: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73a5d0a6-ceb0-4c47-9992-260828f074d0@kernel.org>
Date: Wed, 23 Apr 2025 17:11:17 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yashwant Varur <yashwant.v@...sung.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, alim.akhtar@...sung.com,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: cs0617.lee@...sung.com, g.naidu@...sung.com, niyas.ahmed@...sung.com
Subject: Re: [PATCH] arm64: dts: exynos: Added the ethernet pin configuration

On 23/04/2025 08:00, Yashwant Varur wrote:
> This patch adds the ethernet pin configuration.


> 
> Signed-off-by: Yashwant Varur <yashwant.v@...sung.com>
> Signed-off-by: Changsub Lee <cs0617.lee@...sung.com>

Incorrect chain or confusing. Who was the author? What is the meaning of
the last SoB?


> ---
>  .../dts/exynos/exynosautov920-pinctrl.dtsi    | 41 +++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi
> index 663e8265cbf5..778584d339d5 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi
> @@ -166,6 +166,24 @@ gph6: gph6-gpio-bank {
>  		interrupt-controller;
>  		#interrupt-cells = <2>;
>  	};
> +
> +	eth0_pps_out: eth0_pps_out {

Please follow DTS coding style carefully. This applies to all commits
you try to send from your downstream/vendor code.

What is more important, I don't really understand why you are doing this
- there is no user of these entries - and commit msg does not help here.


Best regards,
Krzysztof