linux-kernel - Re: [PATCH v2] wifi: mac80211: Prevent disconnect reports when no AP is associated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ed3cfbc1a5b80bb3577f73b8c2b19ce830eeff5.camel@sipsolutions.net>
Date: Wed, 23 Apr 2025 17:26:44 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Zhongqiu Han <quic_zhonhan@...cinc.com>, 
	miriam.rachel.korenblit@...el.com
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, 
	syzbot+5a7b40bcb34dea5ca959@...kaller.appspotmail.com
Subject: Re: [PATCH v2] wifi: mac80211: Prevent disconnect reports when no
 AP is associated

On Fri, 2025-03-14 at 20:06 +0800, Zhongqiu Han wrote:
> 
> +++ b/net/mac80211/mlme.c
> @@ -4433,6 +4433,10 @@ static void ieee80211_report_disconnect(struct ieee80211_sub_if_data *sdata,
>  		.u.mlme.data = tx ? DEAUTH_TX_EVENT : DEAUTH_RX_EVENT,
>  		.u.mlme.reason = reason,
>  	};
> +	struct sta_info *ap_sta = sta_info_get(sdata, sdata->vif.cfg.ap_addr);
> +
> +	if (WARN_ON(!ap_sta))
> +		return;

You're adding a WARN_ON() that's now guaranteed to trigger, no?
Shouldn't the caller (also) be fixed?

> @@ -8090,7 +8094,7 @@ static void ieee80211_sta_timer(struct timer_list *t)
>  void ieee80211_sta_connection_lost(struct ieee80211_sub_if_data *sdata,
>  				   u8 reason, bool tx)
>  {
> -	u8 frame_buf[IEEE80211_DEAUTH_FRAME_LEN];
> +	u8 frame_buf[IEEE80211_DEAUTH_FRAME_LEN] = {0};
> 

And that's not needed then? And perhaps should be {} if it is.

johannes