linux-kernel - Re: [PATCH v2 1/6] dt-bindings: pwm: marvell,pxa-pwm: Add SpacemiT K1 PWM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <174542285923.570390.16199020429609870497.robh@kernel.org>
Date: Wed, 23 Apr 2025 10:40:59 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Guodong Xu <guodong@...cstar.com>
Cc: p.zabel@...gutronix.de, hal.feng@...rfivetech.com, elder@...cstar.com,
	aou@...s.berkeley.edu, linux-riscv@...ts.infradead.org,
	paul.walmsley@...ive.com, spacemit@...ts.linux.dev,
	conor+dt@...nel.org, dlan@...too.org, inochiama@...il.com,
	palmer@...belt.com, linux-pwm@...r.kernel.org, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, drew@...7.com,
	devicetree@...r.kernel.org, geert+renesas@...der.be,
	krzk+dt@...nel.org, heylenay@....org, duje.mihanovic@...le.hr,
	ukleinek@...nel.org, alex@...ti.fr, unicorn_wang@...look.com
Subject: Re: [PATCH v2 1/6] dt-bindings: pwm: marvell,pxa-pwm: Add SpacemiT
 K1 PWM support


On Sun, 20 Apr 2025 15:02:46 +0800, Guodong Xu wrote:
> The SpacemiT K1 SoC reuses the Marvell PXA910-compatible PWM controller
> with one notable difference: the addition of a resets property. To make
> the device tree pass schema validation (make dtbs_check W=3), this patch
> updates the binding to accept spacemit,k1-pwm as a compatible string, when
> used in conjunction with the fallback marvell,pxa910-pwm.
> 
> Support for the optional resets property is also added, as it is required
> by the K1 integration but was not present in the original Marvell bindings.
> 
> Since the PWM reset line may be deasserted during the early bootloader
> stage, making the resets property optional avoids potential
> double-deassertion, which could otherwise cause flickering on displays
> that use PWM for backlight control.
> 
> Signed-off-by: Guodong Xu <guodong@...cstar.com>
> ---
> v2: Accept spacemit,k1-pwm as a compatible string, when used in conjunction
>     with the fallback marvell,pxa910-pwm
> 
> .../bindings/pwm/marvell,pxa-pwm.yaml           | 17 ++++++++++++-----
>  1 file changed, 12 insertions(+), 5 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>