linux-kernel - Re: [PATCH v2 1/3] cfg80211: Restore initial state on failed device_rename() in cfg80211_switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a91f731c49d3449632f19dcf4a1a8f5a9eb847b.camel@sipsolutions.net>
Date: Wed, 23 Apr 2025 17:44:45 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Ivan Abramov <i.abramov@...integration.ru>
Cc: Kuniyuki Iwashima <kuniyu@...zon.com>, linux-wireless@...r.kernel.org, 
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/3] cfg80211: Restore initial state on failed
 device_rename() in cfg80211_switch_netns()

On Mon, 2025-04-07 at 15:53 +0300, Ivan Abramov wrote:
> Currently, the return value of device_rename() is not acted upon.
> 
> To avoid an inconsistent state in case of failure, roll back the changes
> made before the device_rename() call.

This kind of seems complicated for something that ought to not happen
...

And also (+netdev), what do we do in case this is called from
cfg80211_pernet_exit() - leak the whole network namespace because we
couldn't allocate memory for the name? That seems counterproductive.

I'm really not convinced of this whole patchset.

johannes