linux-kernel - Re: [PATCH net-next] xdp: create locked/unlocked instances of xdp redirect target setters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <174537783324.2126900.9923938841011183319.git-patchwork-notify@kernel.org>
Date: Wed, 23 Apr 2025 03:10:33 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Joshua Washington <joshwash@...gle.com>
Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, almasrymina@...gle.com,
 willemb@...gle.com, hramamurthy@...gle.com, jeroendb@...gle.com,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, ast@...nel.org, daniel@...earbox.net,
 hawk@...nel.org, john.fastabend@...il.com, horms@...nel.org,
 pkaligineedi@...gle.com, shailend@...gle.com, sdf@...ichev.me,
 martin.lau@...nel.org, jdamato@...tly.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] xdp: create locked/unlocked instances of xdp
 redirect target setters

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 21 Apr 2025 18:16:32 -0700 you wrote:
> Commit 03df156dd3a6 ("xdp: double protect netdev->xdp_flags with
> netdev->lock") introduces the netdev lock to xdp_set_features_flag().
> The change includes a _locked version of the method, as it is possible
> for a driver to have already acquired the netdev lock before calling
> this helper. However, the same applies to
> xdp_features_(set|clear)_redirect_flags(), which ends up calling the
> unlocked version of xdp_set_features_flags() leading to deadlocks in
> GVE, which grabs the netdev lock as part of its suspend, reset, and
> shutdown processes:
> 
> [...]

Here is the summary with links:
  - [net-next] xdp: create locked/unlocked instances of xdp redirect target setters
    https://git.kernel.org/netdev/net-next/c/0e0a7e3719bc

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html