linux-kernel - Re: [PATCH v5 2/2] media: i2c: Add driver for ST VD55G1 camera sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAkLvCqsJ9Tf-O2d@kekkonen.localdomain>
Date: Wed, 23 Apr 2025 15:48:12 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
	Sylvain Petinot <sylvain.petinot@...s.st.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/2] media: i2c: Add driver for ST VD55G1 camera sensor

Hi Laurent,

On Tue, Apr 22, 2025 at 06:07:46PM +0300, Laurent Pinchart wrote:
> Hi Benjamin,
> 
> Thank you for the patch.
> 
> On Fri, Apr 04, 2025 at 04:50:52PM +0200, Benjamin Mugnier wrote:
> > The VD55G1 is a monochrome global shutter camera with a 804x704 maximum
> > resolution with RAW8 and RAW10 bytes per pixel.
> > The driver supports :
> > - Auto exposure from the sensor, or manual exposure mode
> > - HDR subtraction mode, allowing edge detection and background removal
> > - Auto exposure cold start, using configuration values from last stream
> > to start the next one
> > - LED GPIOs for illumination
> > - Most standard camera sensor features (hblank, vblank, test patterns,
> > again, dgain, hflip, vflip, auto exposure bias, etc.)
> > Add driver source code to MAINTAINERS file.
> > 
> > Signed-off-by: Benjamin Mugnier <benjamin.mugnier@...s.st.com>
> > ---
> >  MAINTAINERS                |    2 +
> >  drivers/media/i2c/Kconfig  |   11 +
> >  drivers/media/i2c/Makefile |    1 +
> >  drivers/media/i2c/vd55g1.c | 2005 ++++++++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 2019 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 4f5e9005063a157de69e81b10f8def9da9e6c04c..9991c5f63e3d49a4e7a6ef0071f3b81825e84eee 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -22416,6 +22416,7 @@ M:	Sylvain Petinot <sylvain.petinot@...s.st.com>
> >  L:	linux-media@...r.kernel.org
> >  S:	Maintained
> >  F:	Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml
> > +F:	drivers/media/i2c/vd55g1.c
> >  
> >  ST VGXY61 DRIVER
> >  M:	Benjamin Mugnier <benjamin.mugnier@...s.st.com>
> > @@ -24801,6 +24802,7 @@ F:	drivers/media/i2c/mt*
> >  F:	drivers/media/i2c/og*
> >  F:	drivers/media/i2c/ov*
> >  F:	drivers/media/i2c/s5*
> > +F:	drivers/media/i2c/vd55g1.c
> >  F:	drivers/media/i2c/vgxy61.c
> 
> I suppose that
> 
> F:	drivers/media/i2c/v*
> 
> would be too broad. Sakari, is it time to create a sensors subdirectory
> (not as a prerequisite for this series of course) ?

Good question. Right now everything is arranged according to the bus the
device attaches to, and camera sensors are practically all I²C devices. I
do anticipate to get some I3C devices in the future, but it's been slow.

Would you create a new directory for cameras under i2c? Should the same be
done to various bridge chips, TV tuners and the few flash controller
drivers we have left?

I don't have much of an opinion on this right now. While the current
arrangement requires some care when changing MAINTAINERS, it works for me.

-- 
Regards,

Sakari Ailus