linux-kernel - Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAkVcaRrMmqXRSFz@smile.fi.intel.com>
Date: Wed, 23 Apr 2025 19:29:37 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Petr Mladek <pmladek@...e.com>, Aditya Garg <gargaditya08@...e.com>,
	Hector Martin <marcan@...can.st>, alyssa@...enzweig.io,
	Sven Peter <sven@...npeter.dev>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Aun-Ali Zaidi <admin@...eit.net>,
	Maxime Ripard <mripard@...nel.org>, airlied@...hat.com,
	Simona Vetter <simona@...ll.ch>,
	Steven Rostedt <rostedt@...dmis.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Jonathan Corbet <corbet@....net>,
	Andrew Morton <akpm@...ux-foundation.org>, apw@...onical.com,
	joe@...ches.com, dwaipayanray1@...il.com, lukas.bulwahn@...il.com,
	Kees Cook <kees@...nel.org>, tamird@...il.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	dri-devel@...ts.freedesktop.org, linux-doc@...r.kernel.org,
	Asahi Linux Mailing List <asahi@...ts.linux.dev>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by
 extending %p4cc

On Wed, Apr 23, 2025 at 04:50:02PM +0200, Geert Uytterhoeven wrote:
> On Wed, 23 Apr 2025 at 15:39, Petr Mladek <pmladek@...e.com> wrote:
> > On Tue 2025-04-22 10:43:59, Geert Uytterhoeven wrote:

...

> > The problem is that the semantic is not the same. The modifiers affect
> > the output ordering of IPv4 addresses while they affect the reading order
> > in case of FourCC code.
> 
> Note that for IPv4 addresses we have %pI4, which BTW also takes [hnbl]
> modifiers.

Ouch, now I think I understand your complain. You mean that the behaviour of
h/n here is different to what it is for IPv4 case?

> > Avoid the confusion by replacing the "n" modifier with "hR", aka
> > reverse host ordering.

Not ideal, but better than 'h'ost / 'r'everse pair. Not giving a tag and not
objecting either if there is a consensus.

-- 
With Best Regards,
Andy Shevchenko