linux-kernel - Re: [PATCH v2 3/3] mfd: exynos-lpass: Fix another error handling path in exynos_lpass

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6af9145e-2682-43d6-8315-223c26c69e18@kernel.org>
Date: Wed, 23 Apr 2025 18:33:49 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>, lee@...nel.org,
 alim.akhtar@...sung.com, s.nawrocki@...sung.com, m.szyprowski@...sung.com,
 ideal.song@...sung.com, beomho.seo@...sung.com
Cc: linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 3/3] mfd: exynos-lpass: Fix another error handling path
 in exynos_lpass_probe()

On 21/04/2025 17:00, Christophe JAILLET wrote:
> If devm_of_platform_populate() fails, some clean-up needs to be done, as
> already done in the remove function.
> 
> Add a new devm_add_action_or_reset() to fix the leak in the probe and
> remove the need of a remove function.
> 
> Fixes: c695abab2429 ("mfd: Add Samsung Exynos Low Power Audio Subsystem driver")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested only.
> 
> Changes in v2:
>   - Use a new devm_add_action_or_reset() to fix the leak in the probe
>     and remove the need of a remove function.
>   - Update the commit description accordingly

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof